Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 2206383002: Add component build documentation. (Closed)

Created:
4 years, 4 months ago by brettw
Modified:
4 years, 4 months ago
Reviewers:
jam
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add component build documentation. This will replace this page: https://www.chromium.org/developers/how-tos/component-build This patch also removes some out-of-date GYP references from a few other places (but not all of them). Committed: https://crrev.com/dbb91a1ba8b11e59bd18b8b8336ae909ba438a8a Cr-Commit-Position: refs/heads/master@{#409607}

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+267 lines, -64 lines) Patch
M docs/android_build_instructions.md View 4 chunks +5 lines, -50 lines 0 comments Download
M docs/clang.md View 5 chunks +12 lines, -12 lines 0 comments Download
A docs/component_build.md View 1 1 chunk +249 lines, -0 lines 0 comments Download
M docs/ninja_build.md View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
brettw
4 years, 4 months ago (2016-08-03 18:31:25 UTC) #2
brettw
.
4 years, 4 months ago (2016-08-03 19:20:14 UTC) #7
jam
lgtm One day, we as a team will have to settle on Sites vs markdown.
4 years, 4 months ago (2016-08-03 19:37:39 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2206383002/20001
4 years, 4 months ago (2016-08-03 19:41:04 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-03 20:15:29 UTC) #11
commit-bot: I haz the power
4 years, 4 months ago (2016-08-03 20:17:04 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/dbb91a1ba8b11e59bd18b8b8336ae909ba438a8a
Cr-Commit-Position: refs/heads/master@{#409607}

Powered by Google App Engine
This is Rietveld 408576698