Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Issue 2206363004: [interpreter] Avoid tier-up when there is an OSR activation. (Closed)

Created:
4 years, 4 months ago by Michael Starzinger
Modified:
4 years, 4 months ago
Reviewers:
rmcilroy
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[interpreter] Avoid tier-up when there is an OSR activation. This makes sure we prevent a tier-up for function which also have an optimized activation of OSR code on the stack. In case the OSR code deoptimizes, it needs the bytecode to still be around. R=rmcilroy@chromium.org TEST=mjsunit/regress/regress-5262 BUG=v8:5262 Committed: https://crrev.com/5671b663f9abf14ca477842e854221de8cb862cf Cr-Commit-Position: refs/heads/master@{#38359}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -2 lines) Patch
M src/compiler.cc View 1 chunk +8 lines, -2 lines 0 comments Download
A test/mjsunit/regress/regress-5262.js View 1 chunk +25 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
Michael Starzinger
4 years, 4 months ago (2016-08-04 14:00:54 UTC) #3
rmcilroy
LGTM, thanks.
4 years, 4 months ago (2016-08-04 15:45:16 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2206363004/1
4 years, 4 months ago (2016-08-05 07:49:48 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-05 07:51:28 UTC) #9
commit-bot: I haz the power
4 years, 4 months ago (2016-08-05 07:55:13 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5671b663f9abf14ca477842e854221de8cb862cf
Cr-Commit-Position: refs/heads/master@{#38359}

Powered by Google App Engine
This is Rietveld 408576698