Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(398)

Side by Side Diff: chrome/browser/resources/md_history/history_list.js

Issue 2206363003: [MD History] Use proper shadows for cards. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@remove_rounding
Patch Set: address comment, fix test Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 Polymer({ 5 Polymer({
6 is: 'history-list', 6 is: 'history-list',
7 7
8 behaviors: [HistoryListBehavior], 8 behaviors: [HistoryListBehavior],
9 9
10 properties: { 10 properties: {
(...skipping 10 matching lines...) Expand all
21 // An array of history entries in reverse chronological order. 21 // An array of history entries in reverse chronological order.
22 historyData_: Array, 22 historyData_: Array,
23 23
24 resultLoadingDisabled_: { 24 resultLoadingDisabled_: {
25 type: Boolean, 25 type: Boolean,
26 value: false, 26 value: false,
27 }, 27 },
28 }, 28 },
29 29
30 listeners: { 30 listeners: {
31 'infinite-list.scroll': 'notifyListScroll_', 31 'scroll': 'notifyListScroll_',
32 'remove-bookmark-stars': 'removeBookmarkStars_', 32 'remove-bookmark-stars': 'removeBookmarkStars_',
33 }, 33 },
34 34
35 /** @override */ 35 /** @override */
36 attached: function() { 36 attached: function() {
37 // It is possible (eg, when middle clicking the reload button) for all other 37 // It is possible (eg, when middle clicking the reload button) for all other
38 // resize events to fire before the list is attached and can be measured. 38 // resize events to fire before the list is attached and can be measured.
39 // Adding another resize here ensures it will get sized correctly. 39 // Adding another resize here ensures it will get sized correctly.
40 /** @type {IronListElement} */(this.$['infinite-list']).notifyResize(); 40 /** @type {IronListElement} */(this.$['infinite-list']).notifyResize();
41 this.$['infinite-list'].scrollTarget = this;
42 this.$['scroll-threshold'].scrollTarget = this;
41 }, 43 },
42 44
43 /** 45 /**
44 * Remove bookmark star for history items with matching URLs. 46 * Remove bookmark star for history items with matching URLs.
45 * @param {{detail: !string}} e 47 * @param {{detail: !string}} e
46 * @private 48 * @private
47 */ 49 */
48 removeBookmarkStars_: function(e) { 50 removeBookmarkStars_: function(e) {
49 var url = e.detail; 51 var url = e.detail;
50 52
(...skipping 118 matching lines...) Expand 10 before | Expand all | Expand 10 after
169 171
170 /** 172 /**
171 * @param {number} index 173 * @param {number} index
172 * @return {string} 174 * @return {string}
173 * @private 175 * @private
174 */ 176 */
175 pathForItem_: function(index) { 177 pathForItem_: function(index) {
176 return 'historyData_.' + index; 178 return 'historyData_.' + index;
177 }, 179 },
178 }); 180 });
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698