Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Unified Diff: chrome/renderer/chrome_content_renderer_client.h

Issue 2206343002: Add metrics for YouTube Flash embed rewrite. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@layers
Patch Set: Addressed comments Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/chrome_content_renderer_client.h
diff --git a/chrome/renderer/chrome_content_renderer_client.h b/chrome/renderer/chrome_content_renderer_client.h
index 2c08a4d2e4c1bee3a4c2a9f5077a84d74aef1f50..c821cba37a12a91f3b0b0d021dacdb47a2f2bc34 100644
--- a/chrome/renderer/chrome_content_renderer_client.h
+++ b/chrome/renderer/chrome_content_renderer_client.h
@@ -74,6 +74,26 @@ class WebSecurityOrigin;
class WebRtcLoggingMessageFilter;
#endif
+namespace internal {
+
+extern const char kFlashYouTubeRewriteUMA[];
+
+// Used for UMA. Values should not be reorderer or reused.
+// SUCCESS refers to an embed properly rewritten. SUCCESS_PARAMS_REWRITE refers
+// to an embed rewritten with the params fixed. SUCCESS_ENABLEJSAPI refers to
+// a rewritten embed even though the JS API was enabled (Chrome Android only).
+// FAILURE_ENABLEJSAPI indicates the embed was not rewritten because the
+// JS API was enabled.
+enum YouTubeRewriteStatus {
+ SUCCESS = 0,
+ SUCCESS_PARAMS_REWRITE = 1,
+ SUCCESS_ENABLEJSAPI = 2,
+ FAILURE_ENABLEJSAPI = 3,
+ NUM_PLUGIN_ERROR // should be kept last
+};
+
+} // namespace internal
+
class ChromeContentRendererClient : public content::ContentRendererClient {
public:
ChromeContentRendererClient();
@@ -162,7 +182,6 @@ class ChromeContentRendererClient : public content::ContentRendererClient {
int embedded_worker_id,
const GURL& url) override;
bool ShouldEnforceWebRTCRoutingPreferences() override;
-
GURL OverrideFlashEmbedWithHTML(const GURL& url) override;
#if defined(ENABLE_SPELLCHECK)

Powered by Google App Engine
This is Rietveld 408576698