Index: chrome/renderer/chrome_content_renderer_client.cc |
diff --git a/chrome/renderer/chrome_content_renderer_client.cc b/chrome/renderer/chrome_content_renderer_client.cc |
index ca5b06b68576d4b1a475ac824db48af0f95cf6d6..d85dc1bd1fe2466c1735540acb4e4a7b577f4bb3 100644 |
--- a/chrome/renderer/chrome_content_renderer_client.cc |
+++ b/chrome/renderer/chrome_content_renderer_client.cc |
@@ -183,8 +183,17 @@ using content::RenderThread; |
using content::WebPluginInfo; |
using extensions::Extension; |
+namespace internal { |
+const char kFlashYouTubeRewriteUMA[] = "Plugin.Flash.YouTubeRewrite"; |
+} |
Alexei Svitkine (slow)
2016/08/08 11:32:34
Nit: // namespace internal
kdsilva
2016/08/08 19:10:20
Done.
|
+ |
namespace { |
+void RecordYouTubeRewriteUMA(internal::YouTubeRewriteStatus status) { |
+ UMA_HISTOGRAM_ENUMERATION(internal::kFlashYouTubeRewriteUMA, status, |
+ internal::NUM_PLUGIN_ERROR); |
+} |
+ |
// Whitelist PPAPI for Android Runtime for Chromium. (See crbug.com/383937) |
#if defined(ENABLE_PLUGINS) |
const char* const kPredefinedAllowedCameraDeviceOrigins[] = { |
@@ -1433,8 +1442,10 @@ GURL ChromeContentRendererClient::OverrideFlashEmbedWithHTML(const GURL& url) { |
// We don't modify any URLs that contain the enablejsapi=1 parameter |
// since the page may be interacting with the YouTube Flash player in |
// Javascript and we don't want to break working content. |
- if (corrected_url.query().find("enablejsapi=1") != std::string::npos) |
+ if (corrected_url.query().find("enablejsapi=1") != std::string::npos) { |
+ RecordYouTubeRewriteUMA(internal::FAILURE_ENABLEJSAPI); |
return GURL(); |
+ } |
// Change the path to use the YouTube HTML5 API |
std::string path = corrected_url.path(); |
@@ -1443,5 +1454,7 @@ GURL ChromeContentRendererClient::OverrideFlashEmbedWithHTML(const GURL& url) { |
url::Replacements<char> r; |
r.SetPath(path.c_str(), url::Component(0, path.length())); |
+ RecordYouTubeRewriteUMA(invalid_url ? internal::SUCCESS_PARAMS_REWRITE |
+ : internal::SUCCESS); |
return corrected_url.ReplaceComponents(r); |
} |