Add metrics for YouTube Flash embed rewrite.

chrome/renderer/chrome_content_renderer_client.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/renderer/chrome_content_renderer_client.h"
 
 #include <memory>
 #include <utility>
 
 #include "base/command_line.h"
@@ skipping 167 matching lines @@
 using blink::WebURLResponse;
 using blink::WebVector;
 using content::PluginInstanceThrottler;
 using content::RenderFrame;
 using content::RenderThread;
 using content::WebPluginInfo;
 using extensions::Extension;
 
 namespace {
 
+enum YouTubeRewriteStatus {
+  SUCCESS = 0,
+  SUCCESS_PARAMS_REWRITE = 1,
+  SUCCESS_ENABLEJSAPI = 2,
+  FAILURE_ENABLEJSAPI = 3,
+  NUM_PLUGIN_ERROR  // should be kept last
+};
+
+const char kFlashYouTubeRewriteUMA[] = "Plugin.Flash.YouTubeRewrite";
+
 // Whitelist PPAPI for Android Runtime for Chromium. (See crbug.com/383937)
 #if defined(ENABLE_PLUGINS)
 const char* const kPredefinedAllowedCameraDeviceOrigins[] = {
   "6EAED1924DB611B6EEF2A664BD077BE7EAD33B8F",
   "4EB74897CB187C7633357C2FE832E0AD6A44883A"
 };
 
 const char* const kPredefinedAllowedCompositorOrigins[] = {
   "6EAED1924DB611B6EEF2A664BD077BE7EAD33B8F",
   "4EB74897CB187C7633357C2FE832E0AD6A44883A"
@@ skipping 1186 matching lines @@
 // information. Also, the enforcement of sending and binding UDP is already done
 // by chrome extension permission model.
 bool ChromeContentRendererClient::ShouldEnforceWebRTCRoutingPreferences() {
 #if defined(ENABLE_EXTENSIONS)
   return !IsStandaloneExtensionProcess();
 #else
   return true;
 #endif
 }
 
+void ChromeContentRendererClient::UpdateUMAMetrics(const int& status,

[mlamouri (slow - plz ping), 2016/08/05 12:51:09]

Maybe name this "RecordYouTubeRewriteUMA"?

And move this inside the anonymous namespace above.

[kdsilva, 2016/08/05 14:33:54]

Done.

+                                                   const int& max) {

[mlamouri (slow - plz ping), 2016/08/05 12:51:09]

s/const int&/int/

[kdsilva, 2016/08/05 14:33:54]

Done.

+  UMA_HISTOGRAM_ENUMERATION(kFlashYouTubeRewriteUMA, status, max);
+}
+
 GURL ChromeContentRendererClient::OverrideFlashEmbedWithHTML(const GURL& url) {
   if (!base::FeatureList::IsEnabled(features::kOverrideYouTubeFlashEmbed))
     return GURL();
 
   if (!url.is_valid())
     return GURL();
 
   // We'll only modify YouTube Flash embeds. The URLs can be recognized since
   // they're in the following form: youtube.com/v/VIDEO_ID. So, we check to see
   // if the given URL does follow that format.
@@ skipping 22 matching lines @@
          (pos = url_str.find("?", pos)) != std::string::npos; pos += 1) {
       url_str.replace(pos, 1, "&");
     }
   }
 
   GURL corrected_url = GURL(url_str);
 
   // We don't modify any URLs that contain the enablejsapi=1 parameter
   // since the page may be interacting with the YouTube Flash player in
   // Javascript and we don't want to break working content.
-  if (corrected_url.query().find("enablejsapi=1") != std::string::npos)
+  if (corrected_url.query().find("enablejsapi=1") != std::string::npos) {
+    UpdateUMAMetrics(FAILURE_ENABLEJSAPI, NUM_PLUGIN_ERROR);
     return GURL();
+  }
 
   // Change the path to use the YouTube HTML5 API
   std::string path = corrected_url.path();
   path.replace(path.find("/v/"), 3, "/embed/");
 
   url::Replacements<char> r;
   r.SetPath(path.c_str(), url::Component(0, path.length()));
 
+  UpdateUMAMetrics(invalid_url ? SUCCESS_PARAMS_REWRITE : SUCCESS,
+                   NUM_PLUGIN_ERROR);
   return corrected_url.ReplaceComponents(r);
 }