Add metrics for YouTube Flash embed rewrite.

chrome/renderer/chrome_content_renderer_client.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/renderer/chrome_content_renderer_client.h"
 
 #include <memory>
 #include <utility>
 
 #include "base/command_line.h"
@@ skipping 167 matching lines @@
 using blink::WebURLResponse;
 using blink::WebVector;
 using content::PluginInstanceThrottler;
 using content::RenderFrame;
 using content::RenderThread;
 using content::WebPluginInfo;
 using extensions::Extension;
 
 namespace {
 
+enum YouTubeRewriteStatus {
+  SUCCESS = 0,
+  SUCCESS_PARAMS_REWRITE = 1,
+  SUCCESS_ENABLEJSAPI = 2,
+  FAILURE_ENABLEJSAPI = 3,
+  NUM_PLUGIN_ERROR = 4

[mlamouri (slow - plz ping), 2016/08/04 12:42:02]

Can you add a comment that says that this one should be kept at the end? Also,
don't add "= 4" so it will automatically increment based on the previous value.

[kdsilva, 2016/08/04 14:13:21]

Done.

+};
+
+const char kFlashYouTubeRewrite[] = "Plugin.Flash.YouTubeRewrite";

[mlamouri (slow - plz ping), 2016/08/04 12:42:02]

Maybe name this `kFlashYouTubeRewriteUma`?

[kdsilva, 2016/08/04 14:13:22]

Done.

+
 // Whitelist PPAPI for Android Runtime for Chromium. (See crbug.com/383937)
 #if defined(ENABLE_PLUGINS)
 const char* const kPredefinedAllowedCameraDeviceOrigins[] = {
   "6EAED1924DB611B6EEF2A664BD077BE7EAD33B8F",
   "4EB74897CB187C7633357C2FE832E0AD6A44883A"
 };
 
 const char* const kPredefinedAllowedCompositorOrigins[] = {
   "6EAED1924DB611B6EEF2A664BD077BE7EAD33B8F",
   "4EB74897CB187C7633357C2FE832E0AD6A44883A"
@@ skipping 1225 matching lines @@
     for (size_t pos = index + 1;
         (pos = url_str.find("?",pos )) != std::string::npos; pos += 1)
       url_str.replace(pos, 1, "&");
   }
 
   GURL corrected_url = GURL(url_str);
 
   // We don't modify any URLs that contain the enablejsapi=1 parameter
   // since the page may be interacting with the YouTube Flash player in
   // Javascript and we don't want to break working content.
-  if (corrected_url.query().find("enablejsapi=1") != std::string::npos)
+  if (corrected_url.query().find("enablejsapi=1") != std::string::npos) {
+    UMA_HISTOGRAM_ENUMERATION(kFlashYouTubeRewrite, FAILURE_ENABLEJSAPI,
+        NUM_PLUGIN_ERROR);
     return GURL();
+  }
 
   // Change the path to use the YouTube HTML5 API
   std::string path = corrected_url.path();
   path.replace(path.find("/v/"), 3, "/embed/");
 
   url::Replacements<char> r;
   r.SetPath(path.c_str(), url::Component(0, path.length()));
 
+   UMA_HISTOGRAM_ENUMERATION(kFlashYouTubeRewrite,
+      invalid_url ? SUCCESS_PARAMS_REWRITE : SUCCESS, NUM_PLUGIN_ERROR);
   return corrected_url.ReplaceComponents(r);
 }