src/crankshaft/x64/lithium-x64.h - Issue 2206333003: [stubs] Convert GrowElementsStub to TurboFan

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/crankshaft/x64/lithium-x64.h

Issue 2206333003: [stubs] Convert GrowElementsStub to TurboFan (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Remove dead code Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/crankshaft/x64/lithium-x64.h

diff --git a/src/crankshaft/x64/lithium-x64.h b/src/crankshaft/x64/lithium-x64.h

index c5322633af70b4853b951252c9183fd8f74b061d..2e7a9c382b009aad7638ea70fa36abb34ca46d7f 100644

--- a/src/crankshaft/x64/lithium-x64.h

+++ b/src/crankshaft/x64/lithium-x64.h

@@ -232,7 +232,7 @@ class LInstruction : public ZoneObject {

bool ClobbersTemps() const { return IsCall(); }

bool ClobbersRegisters() const { return IsCall(); }

virtual bool ClobbersDoubleRegisters(Isolate* isolate) const {

- return IsCall();

+ return IsCall() || opcode() == LInstruction::kMaybeGrowElements;

Benedikt Meurer 2016/08/05 04:35:21 I guess since this is virtual, the proper way to d

}

// Interface to the register allocator and iterators.

« src/code-stubs.cc ('K') | « src/crankshaft/mips64/lithium-mips64.h ('k') | no next file » | no next file with comments »