Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Unified Diff: src/code-stubs.h

Issue 2206333003: [stubs] Convert GrowElementsStub to TurboFan (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Rebase Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/code-stub-assembler.cc ('k') | src/code-stubs.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/code-stubs.h
diff --git a/src/code-stubs.h b/src/code-stubs.h
index 1d78d1e07e8cc716564a41a9a6656fb92ba67ea7..17b193e748e0fbd92537980d8a0305fe46b090e7 100644
--- a/src/code-stubs.h
+++ b/src/code-stubs.h
@@ -68,7 +68,6 @@ namespace internal {
/* --- HydrogenCodeStubs --- */ \
V(ElementsTransitionAndStore) \
V(FastCloneShallowArray) \
- V(GrowArrayElements) \
V(NumberToString) \
V(StringAdd) \
V(ToObject) \
@@ -165,6 +164,7 @@ namespace internal {
V(StoreInterceptor) \
V(LoadApiGetter) \
V(LoadIndexedInterceptor) \
+ V(GrowArrayElements) \
/* These are only called from FGC and */ \
/* can be removed when we use ignition */ \
/* only */ \
@@ -1243,26 +1243,22 @@ class CreateWeakCellStub : public TurboFanCodeStub {
DEFINE_TURBOFAN_CODE_STUB(CreateWeakCell, TurboFanCodeStub);
};
-class GrowArrayElementsStub : public HydrogenCodeStub {
+class GrowArrayElementsStub : public TurboFanCodeStub {
public:
- GrowArrayElementsStub(Isolate* isolate, bool is_js_array, ElementsKind kind)
- : HydrogenCodeStub(isolate) {
- set_sub_minor_key(ElementsKindBits::encode(kind) |
- IsJsArrayBits::encode(is_js_array));
+ GrowArrayElementsStub(Isolate* isolate, ElementsKind kind)
+ : TurboFanCodeStub(isolate) {
+ minor_key_ = ElementsKindBits::encode(GetHoleyElementsKind(kind));
}
ElementsKind elements_kind() const {
- return ElementsKindBits::decode(sub_minor_key());
+ return ElementsKindBits::decode(minor_key_);
}
- bool is_js_array() const { return IsJsArrayBits::decode(sub_minor_key()); }
-
private:
class ElementsKindBits : public BitField<ElementsKind, 0, 8> {};
- class IsJsArrayBits : public BitField<bool, ElementsKindBits::kNext, 1> {};
DEFINE_CALL_INTERFACE_DESCRIPTOR(GrowArrayElements);
- DEFINE_HYDROGEN_CODE_STUB(GrowArrayElements, HydrogenCodeStub);
+ DEFINE_TURBOFAN_CODE_STUB(GrowArrayElements, TurboFanCodeStub);
};
class FastArrayPushStub : public HydrogenCodeStub {
« no previous file with comments | « src/code-stub-assembler.cc ('k') | src/code-stubs.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698