[stubs] Convert GrowElementsStub to TurboFan

[stubs] Convert GrowElementsStub to TurboFan

One caveat: the Crankshaft stub used to preserve callee-clobbered double
registers, which is contrary to any real platform ABI that we support. Since the
only current use of this stub is in Crankshaft, the instruction there now must
be marked as double-clobbering. This might result in a small performance
regression. However, when this stub is eventually used in TF-generated code, it
will be called from deferred code that can save doubles only on the rarely-taken
path... something that Crankshaft can't do.

BUG=chromium:608675
Committed: https://crrev.com/eb841269235e6b438b75930878a8cb3ca745014c
Cr-Commit-Position: refs/heads/master@{#38371}

[danno, 2016-08-04 21:43:29]

The CQ bit was checked by danno@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-04 21:43:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[danno, 2016-08-04 22:28:32]

The CQ bit was checked by danno@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-04 22:28:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-04 22:49:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-04 22:49:28]

Dry run: This issue passed the CQ dry run.

[danno, 2016-08-04 22:53:47]

danno@chromium.org changed reviewers:
+ bmeurer@chromium.org, mstarzinger@chromium.org

[danno, 2016-08-04 22:53:48]

ptal

[Benedikt Meurer, 2016-08-05 04:35:21]

LGTM, thanks.

https://codereview.chromium.org/2206333003/diff/80001/src/code-stubs.cc
File src/code-stubs.cc (right):

https://codereview.chromium.org/2206333003/diff/80001/src/code-stubs.cc#newco...
src/code-stubs.cc:5015: // TODO(danno): Make this a tail call when the stub is
only used from TurboFan
Ouch!

https://codereview.chromium.org/2206333003/diff/80001/src/crankshaft/x64/lith...
File src/crankshaft/x64/lithium-x64.h (right):

https://codereview.chromium.org/2206333003/diff/80001/src/crankshaft/x64/lith...
src/crankshaft/x64/lithium-x64.h:235: return IsCall() || opcode() ==
LInstruction::kMaybeGrowElements;
I guess since this is virtual, the proper way to do this would be to override
the method in LMaybeGrowElements to return true. But after all it's Crankshaft
and deprecated, so I don't care really...

[danno, 2016-08-05 09:29:38]

The CQ bit was checked by danno@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-05 09:29:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-05 09:44:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-05 09:44:23]

Dry run: Try jobs failed on following builders:
  v8_win_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win_rel_ng/builds/11908)

[danno, 2016-08-05 09:52:50]

The CQ bit was checked by danno@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-05 09:52:59]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-05 09:55:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-05 09:55:10]

Dry run: Try jobs failed on following builders:
  v8_linux64_avx2_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng/buil...)
  v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng/build...)
  v8_linux64_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel_ng/builds/10400)
  v8_linux_arm_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel_ng/builds/...)
  v8_linux_dbg_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg_ng/builds/10386)
  v8_linux_gcc_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_gcc_compile_rel/bu...)
  v8_linux_mipsel_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mipsel_compile_rel...)

[danno, 2016-08-05 10:43:50]

The CQ bit was checked by danno@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-05 10:44:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-05 11:05:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-05 11:05:47]

Dry run: This issue passed the CQ dry run.

[danno, 2016-08-05 11:10:10]

The CQ bit was checked by danno@chromium.org

[danno, 2016-08-05 11:10:11]

The patchset sent to the CQ was uploaded after l-g-t-m from bmeurer@chromium.org
Link to the patchset: https://codereview.chromium.org/2206333003/#ps140001
(title: "Rebase")

[commit-bot: I haz the power, 2016-08-05 11:10:16]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-05 11:12:18]

Committed patchset #8 (id:140001)

[commit-bot: I haz the power, 2016-08-05 11:14:08]

Description was changed from

==========
[stubs] Convert GrowElementsStub to TurboFan

One caveat: the Crankshaft stub used to preserve callee-clobbered double
registers, which is contrary to any real platform ABI that we support. Since the
only current use of this stub is in Crankshaft, the instruction there now must
be marked as double-clobbering. This might result in a small performance
regression. However, when this stub is eventually used in TF-generated code, it
will be called from deferred code that can save doubles only on the rarely-taken
path... something that Crankshaft can't do.

BUG=chromium:608675
==========

to

==========
[stubs] Convert GrowElementsStub to TurboFan

One caveat: the Crankshaft stub used to preserve callee-clobbered double
registers, which is contrary to any real platform ABI that we support. Since the
only current use of this stub is in Crankshaft, the instruction there now must
be marked as double-clobbering. This might result in a small performance
regression. However, when this stub is eventually used in TF-generated code, it
will be called from deferred code that can save doubles only on the rarely-taken
path... something that Crankshaft can't do.

BUG=chromium:608675

Committed: https://crrev.com/eb841269235e6b438b75930878a8cb3ca745014c
Cr-Commit-Position: refs/heads/master@{#38371}
==========

[commit-bot: I haz the power, 2016-08-05 11:14:09]

Patchset 8 (id:??) landed as
https://crrev.com/eb841269235e6b438b75930878a8cb3ca745014c
Cr-Commit-Position: refs/heads/master@{#38371}