Handle stack overflows in NoSideEffectToString

Handle stack overflows in NoSideEffectToString

An infinite recursion can be triggered when NoSideEffectToString is
called on an error object with its name property set to itself.

BUG=633998
Committed: https://crrev.com/ea6b9609a67b78f5f8d327c578e931d4db2a5268
Cr-Commit-Position: refs/heads/master@{#38325}

[jgruber, 2016-08-03 16:18:36]

The CQ bit was checked by jgruber@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-03 16:18:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jgruber, 2016-08-03 16:21:07]

jgruber@chromium.org changed reviewers:
+ yangguo@chromium.org

[commit-bot: I haz the power, 2016-08-03 16:32:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-03 16:32:58]

Dry run: Try jobs failed on following builders:
  v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng/build...)
  v8_linux64_gyp_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng_trigg...)

[Yang, 2016-08-04 06:36:19]

https://codereview.chromium.org/2206313002/diff/1/src/objects.cc
File src/objects.cc (right):

https://codereview.chromium.org/2206313002/diff/1/src/objects.cc#newcode239
src/objects.cc:239: : Object::NoSideEffectsToString(isolate, name);
Can we simply break the recursion by not calling NoSideEffectsToString, and
instead just use empty string for name or msg if the property is not already a
string?

https://codereview.chromium.org/2206313002/diff/1/src/objects.cc#newcode329
src/objects.cc:329: ctor_name = NoSideEffectsToString(isolate, ctor_name_obj);
Same here.

[jgruber, 2016-08-04 07:11:33]

The CQ bit was checked by jgruber@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-04 07:11:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jgruber, 2016-08-04 07:12:06]

https://codereview.chromium.org/2206313002/diff/1/src/objects.cc
File src/objects.cc (right):

https://codereview.chromium.org/2206313002/diff/1/src/objects.cc#newcode239
src/objects.cc:239: : Object::NoSideEffectsToString(isolate, name);
On 2016/08/04 06:36:19, Yang wrote:
> Can we simply break the recursion by not calling NoSideEffectsToString, and
> instead just use empty string for name or msg if the property is not already a
> string?

Done.

https://codereview.chromium.org/2206313002/diff/1/src/objects.cc#newcode329
src/objects.cc:329: ctor_name = NoSideEffectsToString(isolate, ctor_name_obj);
On 2016/08/04 06:36:19, Yang wrote:
> Same here.

Done.

[Yang, 2016-08-04 07:18:05]

LGTM. Let's pray to the LayoutTest gods that they don't have any hard-coded
expectations about this.

[commit-bot: I haz the power, 2016-08-04 07:34:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-04 07:34:32]

Dry run: This issue passed the CQ dry run.

[jgruber, 2016-08-04 07:36:07]

On 2016/08/04 07:18:05, Yang wrote:
> LGTM. Let's pray to the LayoutTest gods that they don't have any hard-coded
> expectations about this.

Seems like the LayoutTest gods are feeling benevolent today.

[jgruber, 2016-08-04 07:36:24]

The CQ bit was checked by jgruber@chromium.org

[commit-bot: I haz the power, 2016-08-04 07:36:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-04 07:42:28]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-08-04 07:45:21]

Description was changed from

==========
Handle stack overflows in NoSideEffectToString

An infinite recursion can be triggered when NoSideEffectToString is
called on an error object with its name property set to itself.

BUG=633998
==========

to

==========
Handle stack overflows in NoSideEffectToString

An infinite recursion can be triggered when NoSideEffectToString is
called on an error object with its name property set to itself.

BUG=633998

Committed: https://crrev.com/ea6b9609a67b78f5f8d327c578e931d4db2a5268
Cr-Commit-Position: refs/heads/master@{#38325}
==========

[commit-bot: I haz the power, 2016-08-04 07:45:21]

Patchset 2 (id:??) landed as
https://crrev.com/ea6b9609a67b78f5f8d327c578e931d4db2a5268
Cr-Commit-Position: refs/heads/master@{#38325}