Add Lock::HandlesMultipleThreadPriorities().

base/synchronization/lock.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef BASE_SYNCHRONIZATION_LOCK_H_
 #define BASE_SYNCHRONIZATION_LOCK_H_
 
 #include "base/base_export.h"
 #include "base/logging.h"
 #include "base/macros.h"
@@ skipping 43 matching lines @@
     bool rv = lock_.Try();
     if (rv) {
       CheckUnheldAndMark();
     }
     return rv;
   }
 
   void AssertAcquired() const;
 #endif  // DCHECK_IS_ON()
 
+  // Whether Lock mitigates priority inversion when used from different thread

[robliao, 2016/08/03 19:30:07]

One more nit: Since we're generalizing this, I would rephrase the comment as
follows.

Whether Lock makes special accommodation under contention when used with threads
of different priorities, including but not limited to priority inheritance of
the lock holder from the lock waiter of a higher priority.

[fdoray, 2016/08/03 19:32:10]

Done.

+  // priorities. Priority inversion is mitigated by allowing a thread that holds
+  // a Lock to run when higher priority threads try to acquire it.

[gab, 2016/08/03 19:36:25]

I think the second sentence is specific to the implementation (i.e. this sounds
like something that should go in the OS_POSIX block and the OS_WIN block already
has its comment)

[fdoray, 2016/08/03 19:46:25]

Done.

+  static bool HandlesMultipleThreadPriorities() {
 #if defined(OS_POSIX)
-  // Whether this platform has priority inheritance available. All locks will
-  // attempt to use the priority inheritance version if available.
-  static bool PriorityInheritanceAvailable() {
     return internal::LockImpl::PriorityInheritanceAvailable();
+#elif defined(OS_WIN)
+    // Windows mitigates priority inversion by randomly boosting the priority of
+    // ready threads.
+    // https://msdn.microsoft.com/library/windows/desktop/ms684831.aspx
+    return true;
+#else
+#error Must specify if the lock handles multiple thread priorities.

[gab, 2016/08/03 19:36:25]

#error Unsupported platform

is sufficient IMO

[fdoray, 2016/08/03 19:46:25]

Done.

+#endif
   }
-#endif
 
 #if defined(OS_POSIX) || defined(OS_WIN)
   // Both Windows and POSIX implementations of ConditionVariable need to be
   // able to see our lock and tweak our debugging counters, as they release and
   // acquire locks inside of their condition variable APIs.
   friend class ConditionVariable;
 #endif
 
  private:
 #if DCHECK_IS_ON()
@@ skipping 54 matching lines @@
   }
 
  private:
   Lock& lock_;
   DISALLOW_COPY_AND_ASSIGN(AutoUnlock);
 };
 
 }  // namespace base
 
 #endif  // BASE_SYNCHRONIZATION_LOCK_H_