Fix FMCallExpression undefined shift behaviour.

xfa/fxfa/fm2js/xfa_simpleexpression_unittest.cpp

+// Copyright 2016 PDFium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "xfa/fxfa/fm2js/xfa_simpleexpression.h"
+
+#include "testing/gtest/include/gtest/gtest.h"
+

[Lei Zhang, 2016/08/03 16:43:23]

extra blank line?

[dsinclair, 2016/08/03 16:55:36]

Done.

+#include "xfa/fxfa/fm2js/xfa_lexer.h"
+
+TEST(FMCallExpression, more_than_32_arguments) {
+  // Use sign as it has 3 object parameters at positions 0, 5, and 6.
+  CXFA_FMIdentifierExpressionn* exp =

[Lei Zhang, 2016/08/03 16:43:23]

std::unique_ptr + release() below?

And some day, std::move()...

[dsinclair, 2016/08/03 16:55:36]

Done.

+      new CXFA_FMIdentifierExpressionn(0, CFX_WideStringC(L"sign"));

[dsinclair, 2016/08/03 14:55:15]

I'll fix the double n's in a followup.

+
+  CFX_ArrayTemplate<CXFA_FMSimpleExpression*>* args =

[Lei Zhang, 2016/08/03 16:43:23]

Ditto.

[dsinclair, 2016/08/03 16:55:36]

Done.

+      new CFX_ArrayTemplate<CXFA_FMSimpleExpression*>();
+  for (size_t i = 0; i < 50; i++)
+    args->Add(new CXFA_FMSimpleExpression(0, TOKnan));
+
+  CXFA_FMCallExpression callExp(0, exp, args, TRUE);
+  CFX_WideTextBuf js;
+  callExp.ToJavaScript(js);
+
+  // Generate the result javascript string.
+  CFX_WideString result = L"sign(";
+  for (size_t i = 0; i < 50; i++) {
+    if (i > 0)
+      result += L", ";
+
+    result += L"foxit_xfa_formcalc_runtime.get_fm_";
+    // Object positions for sign() method.
+    if (i == 0 || i == 5 || i == 6)
+      result += L"jsobj()";
+    else
+      result += L"value()";
+  }
+  result += L")";
+
+  EXPECT_EQ(result.AsStringC(), js.AsStringC());
+}