DevTools: make iframe nodes report correct frame they belong to

DevTools: make iframe nodes report correct frame they belong to

Technically, the iframe node belongs to the parent frame. The patch
changes the WI.DOMNode.frameId method to correspond to this logic.

BUG=633167
R=dgozman

Committed: https://crrev.com/c43dd9a10d97cad56ac0d8780ac93947a0edeb4f
Cr-Commit-Position: refs/heads/master@{#409611}

[lushnikov, 2016-08-03 16:45:15]

please, take a look

[dgozman, 2016-08-03 16:53:13]

https://codereview.chromium.org/2206153002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/sdk/DOMModel.js (right):

https://codereview.chromium.org/2206153002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/sdk/DOMModel.js:606: var node =
this.parentNode || this;
Does this work for immediate children of iframe now? Let's add such a testcase.

https://codereview.chromium.org/2206153002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/sdk/DOMModel.js:609: return
node._frameId;
Should we change _frameId instead?

[lushnikov, 2016-08-03 18:00:08]

https://codereview.chromium.org/2206153002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/sdk/DOMModel.js (right):

https://codereview.chromium.org/2206153002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/sdk/DOMModel.js:606: var node =
this.parentNode || this;
On 2016/08/03 16:53:13, dgozman wrote:
> Does this work for immediate children of iframe now? Let's add such a
testcase.

Yes; added test.

https://codereview.chromium.org/2206153002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/sdk/DOMModel.js:609: return
node._frameId;
On 2016/08/03 16:53:13, dgozman wrote:
> Should we change _frameId instead?

Renamed into frameOwnerFrameId to avoid confusion

[lushnikov, 2016-08-03 18:43:07]

The CQ bit was checked by lushnikov@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-03 18:44:03]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dgozman, 2016-08-03 18:55:06]

lgtm

[lushnikov, 2016-08-03 19:28:52]

The CQ bit was unchecked by lushnikov@chromium.org

[lushnikov, 2016-08-03 19:28:53]

The CQ bit was checked by lushnikov@chromium.org

[commit-bot: I haz the power, 2016-08-03 19:29:15]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-03 20:24:15]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-08-03 20:25:38]

Description was changed from

==========
DevTools: make iframe nodes report correct frame they belong to

Technically, the iframe node belongs to the parent frame. The patch
changes the WI.DOMNode.frameId method to correspond to this logic.

BUG=633167
R=dgozman
==========

to

==========
DevTools: make iframe nodes report correct frame they belong to

Technically, the iframe node belongs to the parent frame. The patch
changes the WI.DOMNode.frameId method to correspond to this logic.

BUG=633167
R=dgozman

Committed: https://crrev.com/c43dd9a10d97cad56ac0d8780ac93947a0edeb4f
Cr-Commit-Position: refs/heads/master@{#409611}
==========

[commit-bot: I haz the power, 2016-08-03 20:25:39]

Patchset 2 (id:??) landed as
https://crrev.com/c43dd9a10d97cad56ac0d8780ac93947a0edeb4f
Cr-Commit-Position: refs/heads/master@{#409611}