Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(622)

Issue 2206073002: [Mac] Fix camel case in variable names. (Closed)

Created:
4 years, 4 months ago by shrike
Modified:
4 years, 4 months ago
Reviewers:
tapted
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Mac] Fix camel case in variable names. In a previous modification of bubble_decoration.mm I mistakenly used camel case instead of hacker case in several places. This cl corrects those mistakes. R=tapted@chromium.org BUG=622779 Committed: https://crrev.com/b680e7233de12405f5e1a3f3ab0147d5715a06fc Cr-Commit-Position: refs/heads/master@{#409550}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -20 lines) Patch
M chrome/browser/ui/cocoa/location_bar/bubble_decoration.mm View 3 chunks +20 lines, -20 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
shrike
PTAL
4 years, 4 months ago (2016-08-02 23:35:18 UTC) #1
tapted
lgtm
4 years, 4 months ago (2016-08-02 23:41:33 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2206073002/1
4 years, 4 months ago (2016-08-03 16:34:27 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-03 17:17:16 UTC) #5
commit-bot: I haz the power
4 years, 4 months ago (2016-08-03 17:19:05 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b680e7233de12405f5e1a3f3ab0147d5715a06fc
Cr-Commit-Position: refs/heads/master@{#409550}

Powered by Google App Engine
This is Rietveld 408576698