content/public/browser/native_web_keyboard_event.h - Issue 2206053002: Use KeyDown instead of RawKeyDown for Android key events.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/browser/native_web_keyboard_event.h

Issue 2206053002: Use KeyDown instead of RawKeyDown for Android key events. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Remove alt-left test case and rename assert method Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/renderer_host/native_web_keyboard_event_android.cc ('K') | « content/public/android/java/src/org/chromium/content/browser/input/ImeAdapter.java ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/browser/native_web_keyboard_event.h

diff --git a/content/public/browser/native_web_keyboard_event.h b/content/public/browser/native_web_keyboard_event.h

index 0e305a62391abca52a2db36151ffeccafa97df81..7b0a9ef0447d18f423bc41900a68c604f1f4d927 100644

--- a/content/public/browser/native_web_keyboard_event.h

+++ b/content/public/browser/native_web_keyboard_event.h

@@ -30,14 +30,7 @@ struct CONTENT_EXPORT NativeWebKeyboardEvent :

explicit NativeWebKeyboardEvent(gfx::NativeEvent native_event);

#if defined(OS_ANDROID)

- NativeWebKeyboardEvent(blink::WebInputEvent::Type type,

- int modifiers,

- double time_secs,

- int keycode,

- int scancode,

- int unicode_character,

- bool is_system_key);

- // Takes ownership of android_key_event.

+ // Takes ownership of android_key_event (allowed to be null).

no sievers 2016/08/08 23:08:51 nit: we can't really enforce the ownership move, s

NativeWebKeyboardEvent(

JNIEnv* env,

const base::android::JavaRef<jobject>& android_key_event,