Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1617)

Unified Diff: content/browser/renderer_host/ime_adapter_android.h

Issue 2206053002: Use KeyDown instead of RawKeyDown for Android key events. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Code review comments and disable test Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « android_webview/test/BUILD.gn ('k') | content/browser/renderer_host/ime_adapter_android.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/renderer_host/ime_adapter_android.h
diff --git a/content/browser/renderer_host/ime_adapter_android.h b/content/browser/renderer_host/ime_adapter_android.h
index ea88d543080254c4a2956a1072cb1cf3d1c8afaa..f181dfa45c2f7db6da562f2a1c9e94d19ba248f2 100644
--- a/content/browser/renderer_host/ime_adapter_android.h
+++ b/content/browser/renderer_host/ime_adapter_android.h
@@ -31,27 +31,17 @@ class ImeAdapterAndroid {
~ImeAdapterAndroid();
// Called from java -> native
- // The java side is responsible to translate android KeyEvent various enums
- // and values into the corresponding blink::WebInputEvent.
bool SendKeyEvent(
JNIEnv* env,
const base::android::JavaParamRef<jobject>&,
const base::android::JavaParamRef<jobject>& original_key_event,
- int action,
- int meta_state,
+ int type,
+ int modifiers,
long event_time,
int key_code,
int scan_code,
bool is_system_key,
int unicode_text);
- // |event_type| is a value of WebInputEvent::Type.
- bool SendSyntheticKeyEvent(JNIEnv*,
- const base::android::JavaParamRef<jobject>&,
- int event_type,
- long timestamp_ms,
- int native_key_code,
- int modifiers,
- int unicode_char);
void SetComposingText(JNIEnv*,
const base::android::JavaParamRef<jobject>& obj,
const base::android::JavaParamRef<jobject>& text,
« no previous file with comments | « android_webview/test/BUILD.gn ('k') | content/browser/renderer_host/ime_adapter_android.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698