mash: Migrate ash::DragImageView to wm common types

mash: Migrate ash::DragImageView to wm common types

It is a dependency of ShelfView, which we're trying to convert.

* Change context parameter to be a WmWindow root_window.
* Initialize Widget using wm common utils.
* Use display::Display to get the device scale factor to size the image.
* Explicitly cancel a drag when a monitor is disconnected. This used to be
handled by marking the aura::Window as not owned by its parent. However,
drags are canceled anyway when monitor disconnects occur -- this just makes
it explicit.
* Added unit test for monitor disconnect during drag.

The DragDropController is not changed because it will likely need to be
refactored or replaced for mus. The new test is written with aura windows
for the same reason.

BUG=633324
TEST=ash_unittests

Committed: https://crrev.com/035dc06b3166034bcf3a06a97304f8d80b04f06c
Cr-Commit-Position: refs/heads/master@{#410161}

[James Cook, 2016-08-02 22:34:35]

The CQ bit was checked by jamescook@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-02 22:35:07]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-02 23:58:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-02 23:58:03]

Dry run: This issue passed the CQ dry run.

[James Cook, 2016-08-05 18:45:50]

Description was changed from

==========
mash: Migrate ash::DragImageView to wm common types

It is a dependency of ShelfView, which we're trying to convert.

* Change context parameter to be a WmWindow root_window
* Initialize Widget using wm common utils
* Use display::Display to get the device scale factor to size the image

BUG=633324
TEST=ash_unittests
==========

to

==========
mash: Migrate ash::DragImageView to wm common types

It is a dependency of ShelfView, which we're trying to convert.

* Change context parameter to be a WmWindow root_window.
* Initialize Widget using wm common utils.
* Use display::Display to get the device scale factor to size the image.
* Explicitly cancel a drag when a monitor is disconnected. This used to be
handled by marking the aura::Window as not owned by its parent. However,
drags are canceled anyway when monitor disconnects occur -- this just makes
it explicit.
* Added unit test for monitor disconnect during drag.

BUG=633324
TEST=ash_unittests
==========

[James Cook, 2016-08-05 18:47:11]

Description was changed from

==========
mash: Migrate ash::DragImageView to wm common types

It is a dependency of ShelfView, which we're trying to convert.

* Change context parameter to be a WmWindow root_window.
* Initialize Widget using wm common utils.
* Use display::Display to get the device scale factor to size the image.
* Explicitly cancel a drag when a monitor is disconnected. This used to be
handled by marking the aura::Window as not owned by its parent. However,
drags are canceled anyway when monitor disconnects occur -- this just makes
it explicit.
* Added unit test for monitor disconnect during drag.

BUG=633324
TEST=ash_unittests
==========

to

==========
mash: Migrate ash::DragImageView to wm common types

It is a dependency of ShelfView, which we're trying to convert.

* Change context parameter to be a WmWindow root_window.
* Initialize Widget using wm common utils.
* Use display::Display to get the device scale factor to size the image.
* Explicitly cancel a drag when a monitor is disconnected. This used to be
handled by marking the aura::Window as not owned by its parent. However,
drags are canceled anyway when monitor disconnects occur -- this just makes
it explicit.
* Added unit test for monitor disconnect during drag.

The DragDropController is not changed because it will likely need to be
refactored or replaced for mus. The new test is written with aura windows
for the same reason.

BUG=633324
TEST=ash_unittests
==========

[James Cook, 2016-08-05 18:59:25]

The CQ bit was checked by jamescook@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-05 19:00:07]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[James Cook, 2016-08-05 19:00:14]

jamescook@chromium.org changed reviewers:
+ msw@chromium.org

[James Cook, 2016-08-05 19:00:15]

msw, please take a look. With this change I think we're down to a single
reference to aura::Window in ShelfView.

[msw, 2016-08-05 19:32:59]

lgtm with minor nits.

https://codereview.chromium.org/2206033002/diff/60001/ash/drag_drop/drag_drop...
File ash/drag_drop/drag_drop_controller.cc (right):

https://codereview.chromium.org/2206033002/diff/60001/ash/drag_drop/drag_drop...
ash/drag_drop/drag_drop_controller.cc:206:
WmWindowAura::Get(source_window)->GetRootWindow(), source));
nit: comment here on the reasoning for using WmWindow::GetRootWindow instead of
aura::Window::GetRootWindow?

https://codereview.chromium.org/2206033002/diff/60001/ash/drag_drop/drag_drop...
File ash/drag_drop/drag_drop_controller.h (right):

https://codereview.chromium.org/2206033002/diff/60001/ash/drag_drop/drag_drop...
ash/drag_drop/drag_drop_controller.h:40: public WindowTreeHostManager::Observer
{
nit: use ash/common/wm_display_observer.h instead?
(even though we might not really converting this directly?)

https://codereview.chromium.org/2206033002/diff/60001/ash/drag_drop/drag_drop...
File ash/drag_drop/drag_drop_controller_unittest.cc (right):

https://codereview.chromium.org/2206033002/diff/60001/ash/drag_drop/drag_drop...
ash/drag_drop/drag_drop_controller_unittest.cc:1065: for
(aura::Window::Windows::iterator iter = root_windows.begin();
nit: for (aura::Window* window : Shell::GetInstance()->GetAllRootWindows())

[commit-bot: I haz the power, 2016-08-05 19:43:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-05 19:43:39]

Dry run: This issue passed the CQ dry run.

[James Cook, 2016-08-05 20:10:12]

https://codereview.chromium.org/2206033002/diff/60001/ash/drag_drop/drag_drop...
File ash/drag_drop/drag_drop_controller.cc (right):

https://codereview.chromium.org/2206033002/diff/60001/ash/drag_drop/drag_drop...
ash/drag_drop/drag_drop_controller.cc:206:
WmWindowAura::Get(source_window)->GetRootWindow(), source));
On 2016/08/05 19:32:58, msw wrote:
> nit: comment here on the reasoning for using WmWindow::GetRootWindow instead
of
> aura::Window::GetRootWindow?

There's no good reason to change it to WmWindow::GetRootWindow, so I put it back
to aura::Window::GetRootWindow.

https://codereview.chromium.org/2206033002/diff/60001/ash/drag_drop/drag_drop...
File ash/drag_drop/drag_drop_controller.h (right):

https://codereview.chromium.org/2206033002/diff/60001/ash/drag_drop/drag_drop...
ash/drag_drop/drag_drop_controller.h:40: public WindowTreeHostManager::Observer
{
On 2016/08/05 19:32:58, msw wrote:
> nit: use ash/common/wm_display_observer.h instead?
> (even though we might not really converting this directly?)

Done.

https://codereview.chromium.org/2206033002/diff/60001/ash/drag_drop/drag_drop...
File ash/drag_drop/drag_drop_controller_unittest.cc (right):

https://codereview.chromium.org/2206033002/diff/60001/ash/drag_drop/drag_drop...
ash/drag_drop/drag_drop_controller_unittest.cc:1065: for
(aura::Window::Windows::iterator iter = root_windows.begin();
On 2016/08/05 19:32:58, msw wrote:
> nit: for (aura::Window* window : Shell::GetInstance()->GetAllRootWindows())

Done.

[James Cook, 2016-08-05 20:10:18]

The CQ bit was checked by jamescook@chromium.org

[James Cook, 2016-08-05 20:10:18]

The patchset sent to the CQ was uploaded after l-g-t-m from msw@chromium.org
Link to the patchset: https://codereview.chromium.org/2206033002/#ps100001
(title: "nits")

[commit-bot: I haz the power, 2016-08-05 20:10:38]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-05 21:14:50]

Description was changed from

==========
mash: Migrate ash::DragImageView to wm common types

It is a dependency of ShelfView, which we're trying to convert.

* Change context parameter to be a WmWindow root_window.
* Initialize Widget using wm common utils.
* Use display::Display to get the device scale factor to size the image.
* Explicitly cancel a drag when a monitor is disconnected. This used to be
handled by marking the aura::Window as not owned by its parent. However,
drags are canceled anyway when monitor disconnects occur -- this just makes
it explicit.
* Added unit test for monitor disconnect during drag.

The DragDropController is not changed because it will likely need to be
refactored or replaced for mus. The new test is written with aura windows
for the same reason.

BUG=633324
TEST=ash_unittests
==========

to

==========
mash: Migrate ash::DragImageView to wm common types

It is a dependency of ShelfView, which we're trying to convert.

* Change context parameter to be a WmWindow root_window.
* Initialize Widget using wm common utils.
* Use display::Display to get the device scale factor to size the image.
* Explicitly cancel a drag when a monitor is disconnected. This used to be
handled by marking the aura::Window as not owned by its parent. However,
drags are canceled anyway when monitor disconnects occur -- this just makes
it explicit.
* Added unit test for monitor disconnect during drag.

The DragDropController is not changed because it will likely need to be
refactored or replaced for mus. The new test is written with aura windows
for the same reason.

BUG=633324
TEST=ash_unittests
==========

[commit-bot: I haz the power, 2016-08-05 21:14:51]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-08-05 21:17:04]

Description was changed from

==========
mash: Migrate ash::DragImageView to wm common types

It is a dependency of ShelfView, which we're trying to convert.

* Change context parameter to be a WmWindow root_window.
* Initialize Widget using wm common utils.
* Use display::Display to get the device scale factor to size the image.
* Explicitly cancel a drag when a monitor is disconnected. This used to be
handled by marking the aura::Window as not owned by its parent. However,
drags are canceled anyway when monitor disconnects occur -- this just makes
it explicit.
* Added unit test for monitor disconnect during drag.

The DragDropController is not changed because it will likely need to be
refactored or replaced for mus. The new test is written with aura windows
for the same reason.

BUG=633324
TEST=ash_unittests
==========

to

==========
mash: Migrate ash::DragImageView to wm common types

It is a dependency of ShelfView, which we're trying to convert.

* Change context parameter to be a WmWindow root_window.
* Initialize Widget using wm common utils.
* Use display::Display to get the device scale factor to size the image.
* Explicitly cancel a drag when a monitor is disconnected. This used to be
handled by marking the aura::Window as not owned by its parent. However,
drags are canceled anyway when monitor disconnects occur -- this just makes
it explicit.
* Added unit test for monitor disconnect during drag.

The DragDropController is not changed because it will likely need to be
refactored or replaced for mus. The new test is written with aura windows
for the same reason.

BUG=633324
TEST=ash_unittests

Committed: https://crrev.com/035dc06b3166034bcf3a06a97304f8d80b04f06c
Cr-Commit-Position: refs/heads/master@{#410161}
==========

[commit-bot: I haz the power, 2016-08-05 21:17:05]

Patchset 6 (id:??) landed as
https://crrev.com/035dc06b3166034bcf3a06a97304f8d80b04f06c
Cr-Commit-Position: refs/heads/master@{#410161}