Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(595)

Issue 2206003002: [M53] IntersectionObserver: send notifications when objects disappear (Closed)

Created:
4 years, 4 months ago by szager1
Modified:
4 years, 4 months ago
Reviewers:
eae
CC:
chromium-reviews, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, blink-reviews, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src@2785
Target Ref:
refs/pending/branch-heads/2785
Project:
chromium
Visibility:
Public.

Description

[M53] IntersectionObserver: send notifications when objects disappear TEST=intersection-observer/display-none.html BUG=621693 TBR=eae@chromium.org NOTRY=true NOPRESUBMIT=true

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -47 lines) Patch
A + third_party/WebKit/LayoutTests/intersection-observer/display-none.html View 3 chunks +35 lines, -29 lines 0 comments Download
A + third_party/WebKit/LayoutTests/intersection-observer/display-none-expected.txt View 2 chunks +15 lines, -14 lines 0 comments Download
M third_party/WebKit/Source/core/dom/IntersectionObservation.cpp View 2 chunks +5 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
szager1
4 years, 4 months ago (2016-08-02 22:02:48 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2206003002/1
4 years, 4 months ago (2016-08-02 22:04:36 UTC) #3
eae
LGTM
4 years, 4 months ago (2016-08-02 22:04:49 UTC) #4
commit-bot: I haz the power
4 years, 4 months ago (2016-08-02 22:07:22 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1)

Powered by Google App Engine
This is Rietveld 408576698