Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(233)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2205963002: C bindings: Fix signed comparsion. (Closed)

Created:
4 years, 4 months ago by vardhan
Modified:
4 years, 4 months ago
Reviewers:
jamesr, viettrungluu
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org, yzshen+mojopublicwatch_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

C bindings: Fix signed comparsion. This is breaking a dependent CL which actually excersizes this codepath. R=viettrungluu@chromium.org, jamesr@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/005e0cc9b4d463991b2f32ec638561b309fc4499

Patch Set 1 #

Patch Set 2 : oops #

Total comments: 2

Patch Set 3 : fix overflow case #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M mojo/public/c/bindings/lib/type_descriptor.c View 1 2 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
vardhan
ptal
4 years, 4 months ago (2016-08-02 19:52:30 UTC) #1
viettrungluu
https://codereview.chromium.org/2205963002/diff/20001/mojo/public/c/bindings/lib/type_descriptor.c File mojo/public/c/bindings/lib/type_descriptor.c (right): https://codereview.chromium.org/2205963002/diff/20001/mojo/public/c/bindings/lib/type_descriptor.c#newcode89 mojo/public/c/bindings/lib/type_descriptor.c:89: assert((char*)pointer->ptr - (char*)pointer < (ptrdiff_t)max_offset); Hmmm. So if ptrdiff_t ...
4 years, 4 months ago (2016-08-02 20:10:30 UTC) #2
vardhan
ptal https://codereview.chromium.org/2205963002/diff/20001/mojo/public/c/bindings/lib/type_descriptor.c File mojo/public/c/bindings/lib/type_descriptor.c (right): https://codereview.chromium.org/2205963002/diff/20001/mojo/public/c/bindings/lib/type_descriptor.c#newcode89 mojo/public/c/bindings/lib/type_descriptor.c:89: assert((char*)pointer->ptr - (char*)pointer < (ptrdiff_t)max_offset); On 2016/08/02 20:10:29, ...
4 years, 4 months ago (2016-08-02 20:28:30 UTC) #3
viettrungluu
lgtm
4 years, 4 months ago (2016-08-03 16:55:33 UTC) #4
vardhan
4 years, 4 months ago (2016-08-03 17:47:42 UTC) #6
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as
005e0cc9b4d463991b2f32ec638561b309fc4499 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698