Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(230)

Side by Side Diff: runtime/vm/service_isolate.cc

Issue 2205953003: Silence service isolate startup error unless --trace-service is enabled (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2015, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2015, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/service_isolate.h" 5 #include "vm/service_isolate.h"
6 6
7 #include "vm/compiler.h" 7 #include "vm/compiler.h"
8 #include "vm/dart_api_impl.h" 8 #include "vm/dart_api_impl.h"
9 #include "vm/dart_entry.h" 9 #include "vm/dart_entry.h"
10 #include "vm/isolate.h" 10 #include "vm/isolate.h"
(...skipping 313 matching lines...) Expand 10 before | Expand all | Expand 10 after
324 324
325 isolate = 325 isolate =
326 reinterpret_cast<Isolate*>(create_callback(ServiceIsolate::kName, 326 reinterpret_cast<Isolate*>(create_callback(ServiceIsolate::kName,
327 NULL, 327 NULL,
328 NULL, 328 NULL,
329 NULL, 329 NULL,
330 &api_flags, 330 &api_flags,
331 NULL, 331 NULL,
332 &error)); 332 &error));
333 if (isolate == NULL) { 333 if (isolate == NULL) {
334 OS::PrintErr("vm-service: Isolate creation error: %s\n", error); 334 if (FLAG_trace_service) {
335 OS::PrintErr("vm-service: Isolate creation error: %s\n", error);
336 }
335 ServiceIsolate::SetServiceIsolate(NULL); 337 ServiceIsolate::SetServiceIsolate(NULL);
336 ServiceIsolate::FinishedInitializing(); 338 ServiceIsolate::FinishedInitializing();
337 ServiceIsolate::FinishedExiting(); 339 ServiceIsolate::FinishedExiting();
338 return; 340 return;
339 } 341 }
340 342
341 bool got_unwind; 343 bool got_unwind;
342 { 344 {
343 ASSERT(Isolate::Current() == NULL); 345 ASSERT(Isolate::Current() == NULL);
344 StartIsolateScope start_scope(isolate); 346 StartIsolateScope start_scope(isolate);
(...skipping 178 matching lines...) Expand 10 before | Expand all | Expand 10 after
523 } 525 }
524 ASSERT(port != ILLEGAL_PORT); 526 ASSERT(port != ILLEGAL_PORT);
525 ServiceIsolate::SetServicePort(port); 527 ServiceIsolate::SetServicePort(port);
526 } 528 }
527 529
528 530
529 void ServiceIsolate::VisitObjectPointers(ObjectPointerVisitor* visitor) { 531 void ServiceIsolate::VisitObjectPointers(ObjectPointerVisitor* visitor) {
530 } 532 }
531 533
532 } // namespace dart 534 } // namespace dart
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698