Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(402)

Issue 220593008: Delete CompositedLayerMapping::updateAfterLayout (Closed)

Created:
6 years, 8 months ago by abarth-chromium
Modified:
6 years, 8 months ago
Reviewers:
ojan
CC:
blink-reviews, bemjb+rendering_chromium.org, dsinclair, zoltan1, eae+blinkwatch, leviw+renderwatch, abarth-chromium, blink-layers+watch_chromium.org, jchaffraix+rendering, pdr., rune+blink, esprehn, ojan, Ian Vollick
Visibility:
Public.

Description

Delete CompositedLayerMapping::updateAfterLayout This function doesn't do much anymore and can be inlined into its one caller. This CL also removes some unnecessary bits in the UpdateLayerPositionsFlags bitfield. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170632

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -27 lines) Patch
M Source/core/frame/FrameView.cpp View 1 chunk +2 lines, -5 lines 0 comments Download
M Source/core/rendering/RenderLayer.h View 2 chunks +4 lines, -7 lines 0 comments Download
M Source/core/rendering/RenderLayer.cpp View 2 chunks +2 lines, -7 lines 0 comments Download
M Source/core/rendering/compositing/CompositedLayerMapping.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/rendering/compositing/CompositedLayerMapping.cpp View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
abarth-chromium
This CL depends on https://codereview.chromium.org/218993017/
6 years, 8 months ago (2014-04-01 21:50:32 UTC) #1
ojan
lgtm <3
6 years, 8 months ago (2014-04-01 21:54:57 UTC) #2
abarth-chromium
The CQ bit was checked by abarth@chromium.org
6 years, 8 months ago (2014-04-02 03:30:21 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abarth@chromium.org/220593008/1
6 years, 8 months ago (2014-04-02 03:30:33 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-02 03:40:56 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on win_blink_rel
6 years, 8 months ago (2014-04-02 03:40:57 UTC) #6
abarth-chromium
The CQ bit was checked by abarth@chromium.org
6 years, 8 months ago (2014-04-02 03:44:25 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abarth@chromium.org/220593008/1
6 years, 8 months ago (2014-04-02 03:44:28 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-02 03:46:25 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on linux_blink_dbg
6 years, 8 months ago (2014-04-02 03:46:26 UTC) #10
abarth-chromium
The CQ bit was checked by abarth@chromium.org
6 years, 8 months ago (2014-04-02 03:50:00 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abarth@chromium.org/220593008/1
6 years, 8 months ago (2014-04-02 03:50:09 UTC) #12
commit-bot: I haz the power
6 years, 8 months ago (2014-04-02 05:17:58 UTC) #13
Message was sent while issue was closed.
Change committed as 170632

Powered by Google App Engine
This is Rietveld 408576698