Fix one of the SSL error pages to work with the new neterror CSS file.

Fix one of the SSL error pages to work with the new neterror CSS file.
This regressed in r255617.

Also add a comment in the CSS file about it being used in other files,
as the dependency is not obvious.

BUG=358523
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=268801

[felt, 2014-04-01 22:31:21]

On 2014/04/01 20:56:26, mmenke wrote:

lgtm

Can you make sure it plays nicely with
https://codereview.chromium.org/212573003/? I'm not sure if that regression was
caused at the same time or not.

[mmenke, 2014-05-06 20:24:51]

[+thakis] for owners review.

[Nico, 2014-05-06 23:08:03]

lgtm

I can't think of a good way to have tests for this :-/ Can you?

https://codereview.chromium.org/220593006/diff/40001/chrome/renderer/resource...
File chrome/renderer/resources/neterror.css (right):

https://codereview.chromium.org/220593006/diff/40001/chrome/renderer/resource...
chrome/renderer/resources/neterror.css:10:
******************************************************************************/
I'm afraid that this file is long enough that people won't see this comment when
changing this file :-/

[mmenke, 2014-05-06 23:34:26]

I'll think a bit more about how to test this, but don't have high hopes.

https://codereview.chromium.org/220593006/diff/40001/chrome/renderer/resource...
File chrome/renderer/resources/neterror.css (right):

https://codereview.chromium.org/220593006/diff/40001/chrome/renderer/resource...
chrome/renderer/resources/neterror.css:10:
******************************************************************************/
On 2014/05/06 23:08:04, Nico wrote:
> I'm afraid that this file is long enough that people won't see this comment
when
> changing this file :-/

You're probably right, but I don't have a better suggestion, unfortunately. 
Ideally, we'd use the same template for all error pages, to make it more
obvious, though even then, it's easy to miss.

We could try checking for the use of undeclared classes, but that wouldn't have
caught this one.

I suppose we could do a layout test, but that doesn't really seem right.  Would
probably take some work to hook one up for the SSL error page, too - they use
interstitials, which are missing a lot of hooks.

[mmenke, 2014-05-06 23:34:30]

The CQ bit was checked by mmenke@chromium.org

[commit-bot: I haz the power, 2014-05-06 23:37:47]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/mmenke@chromium.org/220593006/40001

[commit-bot: I haz the power, 2014-05-07 16:18:55]

Change committed as 268801