Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(514)

Unified Diff: net/quic/core/quic_stream_sequencer_buffer_test.cc

Issue 2205923002: Fix to make sure QuicStreamSequencerBuffer release memory in time. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/core/quic_stream_sequencer_buffer.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/core/quic_stream_sequencer_buffer_test.cc
diff --git a/net/quic/core/quic_stream_sequencer_buffer_test.cc b/net/quic/core/quic_stream_sequencer_buffer_test.cc
index b020e6992700ad85431c4b5297e71c930121e4c2..655b13a62b78bddf6f440f8c6775e8deb74ad5a8 100644
--- a/net/quic/core/quic_stream_sequencer_buffer_test.cc
+++ b/net/quic/core/quic_stream_sequencer_buffer_test.cc
@@ -403,6 +403,10 @@ TEST_F(QuicStreamSequencerBufferTest, Readv100Bytes) {
EXPECT_EQ(100u, buffer_->BytesConsumed());
EXPECT_EQ(source, string(dest, read));
EXPECT_EQ(1u, helper_->frame_arrival_time_map()->size());
+ if (FLAGS_quic_sequencer_buffer_retire_block_in_time) {
+ // The first block should be released as its data has been read out.
+ EXPECT_EQ(nullptr, helper_->GetBlock(0));
+ }
EXPECT_TRUE(helper_->CheckBufferInvariants());
}
« no previous file with comments | « net/quic/core/quic_stream_sequencer_buffer.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698