Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2205913003: Better error-message when bind fails. (Closed)

Created:
4 years, 4 months ago by floitsch
Modified:
4 years, 4 months ago
Reviewers:
Søren Gjesse
CC:
reviews_dartlang.org, vm-dev_dartlang.org, rmacnak
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Don't use 'errno' as variable name. #

Patch Set 3 : Update Changelog. #

Total comments: 2

Patch Set 4 : Reupload after revert #

Patch Set 5 : Avoid fuzzing issues, by making function non-static. #

Patch Set 6 : Reupload after revert #

Patch Set 7 : Add android support. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -2 lines) Patch
M CHANGELOG.md View 1 2 3 1 chunk +5 lines, -0 lines 0 comments Download
M runtime/bin/io_natives.cc View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M runtime/bin/socket.h View 1 chunk +3 lines, -0 lines 0 comments Download
M runtime/bin/socket.cc View 1 2 3 4 1 chunk +6 lines, -0 lines 0 comments Download
M runtime/bin/socket_android.cc View 1 2 3 4 5 6 1 chunk +6 lines, -0 lines 0 comments Download
M runtime/bin/socket_fuchsia.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M runtime/bin/socket_linux.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M runtime/bin/socket_macos.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M runtime/bin/socket_patch.dart View 1 2 3 4 2 chunks +8 lines, -1 line 0 comments Download
M runtime/bin/socket_unsupported.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M runtime/bin/socket_win.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M tests/standalone/io/socket_source_address_test.dart View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 19 (8 generated)
floitsch
4 years, 4 months ago (2016-08-02 17:44:18 UTC) #2
Søren Gjesse
lgtm https://codereview.chromium.org/2205913003/diff/40001/runtime/bin/socket_linux.cc File runtime/bin/socket_linux.cc (right): https://codereview.chromium.org/2205913003/diff/40001/runtime/bin/socket_linux.cc#newcode106 runtime/bin/socket_linux.cc:106: error_number == EINVAL; Can't EINVAL also be a ...
4 years, 4 months ago (2016-08-03 07:15:02 UTC) #3
floitsch
https://codereview.chromium.org/2205913003/diff/40001/runtime/bin/socket_linux.cc File runtime/bin/socket_linux.cc (right): https://codereview.chromium.org/2205913003/diff/40001/runtime/bin/socket_linux.cc#newcode106 runtime/bin/socket_linux.cc:106: error_number == EINVAL; On 2016/08/03 07:15:02, Søren Gjesse wrote: ...
4 years, 4 months ago (2016-08-03 09:23:43 UTC) #4
floitsch
Committed patchset #3 (id:40001) manually as 34aed6a08b8547a985ac701cf3910a5f5450dd52 (presubmit successful).
4 years, 4 months ago (2016-08-03 13:29:48 UTC) #6
floitsch
As discussed: made the function non-static. TBR.
4 years, 4 months ago (2016-08-03 14:22:01 UTC) #8
floitsch
Committed patchset #5 (id:80001) manually as 8c4954492f0593f41d270691bb82c26d8509c894 (presubmit successful).
4 years, 4 months ago (2016-08-03 14:27:55 UTC) #10
Søren Gjesse
lgtm
4 years, 4 months ago (2016-08-03 14:38:49 UTC) #11
floitsch
I forgot to save a file... Resubmitting. TBR.
4 years, 4 months ago (2016-08-03 20:44:01 UTC) #13
floitsch
Committed patchset #7 (id:120001) manually as eaeb260244d524b54d3ec842af2f8400cd543b12 (presubmit successful).
4 years, 4 months ago (2016-08-03 20:44:34 UTC) #15
Søren Gjesse
lgtm!
4 years, 4 months ago (2016-08-04 06:55:54 UTC) #16
floitsch
4 years, 4 months ago (2016-08-04 12:45:13 UTC) #19
Message was sent while issue was closed. 
Committed patchset #7 (id:120001) manually as
ef4933df25e61f5a36008a1d5cd560f580837715 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698