third_party/WebKit/Source/platform/v8_inspector/V8InspectorSessionImpl.cpp - Issue 2205913002: [DevTools] Split a part of V8Inspector into V8Debugger.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/v8_inspector/V8InspectorSessionImpl.cpp

Issue 2205913002: [DevTools] Split a part of V8Inspector into V8Debugger. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@v8-inspector-rename

Patch Set: context scope! Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/v8_inspector/V8InspectorImpl.cpp ('k') | third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/v8_inspector/V8InspectorSessionImpl.cpp

diff --git a/third_party/WebKit/Source/platform/v8_inspector/V8InspectorSessionImpl.cpp b/third_party/WebKit/Source/platform/v8_inspector/V8InspectorSessionImpl.cpp

index c2901d28d5845e5b10df5323c2839f891f040a84..0d5656b55431bccb257a065e77d6f4f43f47f9b3 100644

--- a/third_party/WebKit/Source/platform/v8_inspector/V8InspectorSessionImpl.cpp

+++ b/third_party/WebKit/Source/platform/v8_inspector/V8InspectorSessionImpl.cpp

@@ -9,6 +9,7 @@

#include "platform/v8_inspector/InspectedContext.h"

#include "platform/v8_inspector/RemoteObjectId.h"

#include "platform/v8_inspector/V8ConsoleAgentImpl.h"

+#include "platform/v8_inspector/V8Debugger.h"

#include "platform/v8_inspector/V8DebuggerAgentImpl.h"

#include "platform/v8_inspector/V8HeapProfilerAgentImpl.h"

#include "platform/v8_inspector/V8InspectorImpl.h"

@@ -216,7 +217,7 @@ std::unique_ptr<protocol::Runtime::API::RemoteObject> V8InspectorSessionImpl::wr

std::unique_ptr<protocol::Runtime::RemoteObject> V8InspectorSessionImpl::wrapObject(v8::Local<v8::Context> context, v8::Local<v8::Value> value, const String16& groupName, bool generatePreview)

{

ErrorString errorString;

- InjectedScript* injectedScript = findInjectedScript(&errorString, V8InspectorImpl::contextId(context));

+ InjectedScript* injectedScript = findInjectedScript(&errorString, V8Debugger::contextId(context));

if (!injectedScript)

return nullptr;

return injectedScript->wrapObject(&errorString, value, groupName, false, generatePreview);

@@ -225,7 +226,7 @@ std::unique_ptr<protocol::Runtime::RemoteObject> V8InspectorSessionImpl::wrapObj

std::unique_ptr<protocol::Runtime::RemoteObject> V8InspectorSessionImpl::wrapTable(v8::Local<v8::Context> context, v8::Local<v8::Value> table, v8::Local<v8::Value> columns)

{

ErrorString errorString;

- InjectedScript* injectedScript = findInjectedScript(&errorString, V8InspectorImpl::contextId(context));

+ InjectedScript* injectedScript = findInjectedScript(&errorString, V8Debugger::contextId(context));

if (!injectedScript)

return nullptr;

return injectedScript->wrapTable(table, columns);