Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(440)

Issue 2205903003: Move chrome/browser/errorpage_browsertest.cc to chrome/browser/net. (Closed)

Created:
4 years, 4 months ago by mmenke
Modified:
4 years, 4 months ago
Reviewers:
Nico
CC:
chromium-reviews, cbentzel+watch_chromium.org, Randy Smith (Not in Mondays)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move chrome/browser/errorpage_browsertest.cc to chrome/browser/net. BUG=none Committed: https://crrev.com/ec732aad75df3788dff99e857d86f4100a48d34a Cr-Commit-Position: refs/heads/master@{#409582}

Patch Set 1 #

Patch Set 2 : Merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1497 lines) Patch
D chrome/browser/errorpage_browsertest.cc View 1 chunk +0 lines, -1497 lines 0 comments Download
A + chrome/browser/net/errorpage_browsertest.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 2 chunks +1 line, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 13 (6 generated)
mmenke
[thakis]: PTAL, thanks! [rdsmith]: FYI
4 years, 4 months ago (2016-08-02 18:32:12 UTC) #2
Nico
lgtm
4 years, 4 months ago (2016-08-02 19:08:50 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2205903003/1
4 years, 4 months ago (2016-08-03 18:01:04 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_clang_dbg_recipe/builds/106533) android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED, ...
4 years, 4 months ago (2016-08-03 18:04:48 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2205903003/20001
4 years, 4 months ago (2016-08-03 18:15:08 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-03 19:01:23 UTC) #11
commit-bot: I haz the power
4 years, 4 months ago (2016-08-03 19:03:31 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ec732aad75df3788dff99e857d86f4100a48d34a
Cr-Commit-Position: refs/heads/master@{#409582}

Powered by Google App Engine
This is Rietveld 408576698