Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(444)

Issue 2205883002: [test] Update testing-variant stages (Closed)

Created:
4 years, 4 months ago by Michael Achenbach
Modified:
4 years, 4 months ago
CC:
v8-reviews_googlegroups.com, Jakob Kummerow, rmcilroy
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[test] Update testing-variant stages This prepares for adding the ignition_staging variant to the default variant set. BUG=v8:5238 Committed: https://crrev.com/3eab4e87daf8e032002473a8cde8614d5d9e45f1 Cr-Commit-Position: refs/heads/master@{#38257}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M tools/run-tests.py View 2 chunks +4 lines, -3 lines 0 comments Download

Messages

Total messages: 17 (11 generated)
Michael Achenbach
PTAL
4 years, 4 months ago (2016-08-02 14:05:22 UTC) #4
Michael Starzinger
LGTM from my side. +Michael Hablich: This should be in accordance with what we talked ...
4 years, 4 months ago (2016-08-02 16:08:49 UTC) #10
Michael Hablich
On 2016/08/02 16:08:49, Michael Starzinger wrote: > LGTM from my side. > > +Michael Hablich: ...
4 years, 4 months ago (2016-08-02 17:09:03 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2205883002/1
4 years, 4 months ago (2016-08-02 17:21:16 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-02 17:22:52 UTC) #15
commit-bot: I haz the power
4 years, 4 months ago (2016-08-02 17:25:49 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3eab4e87daf8e032002473a8cde8614d5d9e45f1
Cr-Commit-Position: refs/heads/master@{#38257}

Powered by Google App Engine
This is Rietveld 408576698