|
|
Created:
4 years, 4 months ago by Michael Achenbach Modified:
4 years, 4 months ago CC:
v8-reviews_googlegroups.com, Jakob Kummerow, rmcilroy Base URL:
https://chromium.googlesource.com/v8/v8.git@master Target Ref:
refs/pending/heads/master Project:
v8 Visibility:
Public. |
Description[test] Update testing-variant stages
This prepares for adding the ignition_staging variant to the
default variant set.
BUG=v8:5238
Committed: https://crrev.com/3eab4e87daf8e032002473a8cde8614d5d9e45f1
Cr-Commit-Position: refs/heads/master@{#38257}
Patch Set 1 #
Messages
Total messages: 17 (11 generated)
Description was changed from ========== [test] Update testing-variant stages BUG= ========== to ========== [test] Update testing-variant stages BUG=v8:5238 ==========
Description was changed from ========== [test] Update testing-variant stages BUG=v8:5238 ========== to ========== [test] Update testing-variant stages This prepares for adding the ignition_staging variant to the default variant set. BUG=v8:5238 ==========
machenbach@chromium.org changed reviewers: + mstarzinger@chromium.org
PTAL
The CQ bit was checked by machenbach@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
mstarzinger@chromium.org changed reviewers: + hablich@chromium.org
LGTM from my side. +Michael Hablich: This should be in accordance with what we talked about yesterday. The moved variants are now in the appropriate buckets and the "dev" set of variants being run locally has room for "ignition_staging" now.
On 2016/08/02 16:08:49, Michael Starzinger wrote: > LGTM from my side. > > +Michael Hablich: This should be in accordance with what we talked about > yesterday. The moved variants are now in the appropriate buckets and the "dev" > set of variants being run locally has room for "ignition_staging" now. Thanks, lgtm!
The CQ bit was checked by machenbach@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== [test] Update testing-variant stages This prepares for adding the ignition_staging variant to the default variant set. BUG=v8:5238 ========== to ========== [test] Update testing-variant stages This prepares for adding the ignition_staging variant to the default variant set. BUG=v8:5238 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== [test] Update testing-variant stages This prepares for adding the ignition_staging variant to the default variant set. BUG=v8:5238 ========== to ========== [test] Update testing-variant stages This prepares for adding the ignition_staging variant to the default variant set. BUG=v8:5238 Committed: https://crrev.com/3eab4e87daf8e032002473a8cde8614d5d9e45f1 Cr-Commit-Position: refs/heads/master@{#38257} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/3eab4e87daf8e032002473a8cde8614d5d9e45f1 Cr-Commit-Position: refs/heads/master@{#38257} |