Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(845)

Unified Diff: third_party/WebKit/Source/devtools/front_end/network/RequestPreviewView.js

Issue 2205853005: [Devtools] Regression fix for double toolbar for images in network (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/devtools/front_end/network/RequestPreviewView.js
diff --git a/third_party/WebKit/Source/devtools/front_end/network/RequestPreviewView.js b/third_party/WebKit/Source/devtools/front_end/network/RequestPreviewView.js
index a316ec37b3998595b8294d609638079f1f38e944..0d2362ecbb0bbe8b90279f6e1b6f53dd0e0337a1 100644
--- a/third_party/WebKit/Source/devtools/front_end/network/RequestPreviewView.js
+++ b/third_party/WebKit/Source/devtools/front_end/network/RequestPreviewView.js
@@ -70,8 +70,9 @@ WebInspector.RequestPreviewView.prototype = {
function handlePreviewView(view)
{
this._previewView = view;
lushnikov 2016/08/03 17:47:08 it looks to me that this._previewView is equal to
+ var isShowing = this._previewView.isShowing();
lushnikov 2016/08/03 17:38:32 Why does this code run everytime you switch to the
this._previewView.show(this.element);
- if (this._previewView instanceof WebInspector.View) {
+ if (!isShowing && this._previewView instanceof WebInspector.View) {
var toolbar = new WebInspector.Toolbar("network-item-preview-toolbar", this.element);
for (var item of /** @type {!WebInspector.View} */ (this._previewView).toolbarItems())
toolbar.appendToolbarItem(item);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698