Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(338)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/network/RequestResponseView.js

Issue 2205853005: [Devtools] Regression fix for double toolbar for images in network (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: [Devtools] Regression fix for double toolbar for images in network Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2011 Google Inc. All rights reserved. 2 * Copyright (C) 2011 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 47 matching lines...) Expand 10 before | Expand all | Expand 10 after
58 { 58 {
59 return new WebInspector.EmptyWidget(message); 59 return new WebInspector.EmptyWidget(message);
60 }, 60 },
61 61
62 contentLoaded: function() 62 contentLoaded: function()
63 { 63 {
64 if ((!this.request.content || !this.sourceView) && !this.request.content Error()) { 64 if ((!this.request.content || !this.sourceView) && !this.request.content Error()) {
65 if (!this._emptyWidget) { 65 if (!this._emptyWidget) {
66 this._emptyWidget = this._createMessageView(WebInspector.UIStrin g("This request has no response data available.")); 66 this._emptyWidget = this._createMessageView(WebInspector.UIStrin g("This request has no response data available."));
67 this._emptyWidget.show(this.element); 67 this._emptyWidget.show(this.element);
68 this.innerView = this._emptyWidget;
69 } 68 }
70 } else { 69 } else {
71 if (this._emptyWidget) { 70 if (this._emptyWidget) {
72 this._emptyWidget.detach(); 71 this._emptyWidget.detach();
73 delete this._emptyWidget; 72 delete this._emptyWidget;
74 } 73 }
75 74
76 if (this.request.content && this.sourceView) { 75 if (this.request.content && this.sourceView) {
77 this.sourceView.show(this.element); 76 this.sourceView.show(this.element);
78 this.innerView = this.sourceView;
79 } else { 77 } else {
80 if (!this._errorView) 78 if (!this._errorView)
81 this._errorView = this._createMessageView(WebInspector.UIStr ing("Failed to load response data")); 79 this._errorView = this._createMessageView(WebInspector.UIStr ing("Failed to load response data"));
82 this._errorView.show(this.element); 80 this._errorView.show(this.element);
83 this.innerView = this._errorView;
84 } 81 }
85 } 82 }
86 }, 83 },
87 84
88 __proto__: WebInspector.RequestContentView.prototype 85 __proto__: WebInspector.RequestContentView.prototype
89 } 86 }
90 87
91 /** 88 /**
92 * @constructor 89 * @constructor
93 * @implements {WebInspector.ContentProvider} 90 * @implements {WebInspector.ContentProvider}
(...skipping 46 matching lines...) Expand 10 before | Expand all | Expand 10 after
140 * @param {string} query 137 * @param {string} query
141 * @param {boolean} caseSensitive 138 * @param {boolean} caseSensitive
142 * @param {boolean} isRegex 139 * @param {boolean} isRegex
143 * @param {function(!Array.<!WebInspector.ContentProvider.SearchMatch>)} cal lback 140 * @param {function(!Array.<!WebInspector.ContentProvider.SearchMatch>)} cal lback
144 */ 141 */
145 searchInContent: function(query, caseSensitive, isRegex, callback) 142 searchInContent: function(query, caseSensitive, isRegex, callback)
146 { 143 {
147 this._request.searchInContent(query, caseSensitive, isRegex, callback); 144 this._request.searchInContent(query, caseSensitive, isRegex, callback);
148 } 145 }
149 } 146 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698