[Devtools] Regression fix for double toolbar for images in network

third_party/WebKit/Source/devtools/front_end/network/RequestPreviewView.js

 /*
  * Copyright (C) 2011 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 30 matching lines @@
 }
 
 WebInspector.RequestPreviewView.prototype = {
     contentLoaded: function()
     {
         if (!this.request.content && !this.request.contentError()) {
             if (!this._emptyWidget) {
                 this._emptyWidget = this._createEmptyWidget();
                 this._emptyWidget.show(this.element);
                 this.innerView = this._emptyWidget;
             }

[lushnikov, 2016/08/03 18:42:15]

let's do a fast return here to reduce code nesting

[allada, 2016/08/03 19:02:26]

Done.

         } else {
             if (this._emptyWidget) {
                 this._emptyWidget.detach();

[lushnikov, 2016/08/03 18:42:14]

this.innerView = null;

[allada, 2016/08/03 19:02:26]

Done.

                 delete this._emptyWidget;
             }
 
-            if (!this._previewView) {
+            if (!this.innerView)

[lushnikov, 2016/08/03 18:42:14]

let's get rid of this.innerView! 

[allada, 2016/08/03 19:02:26]

Done.

                 this._createPreviewView(handlePreviewView.bind(this));
-            } else {
-                this.innerView = this._previewView;
-                handlePreviewView.call(this, this.innerView);
-            }
+            else
+                this.innerView.show(this.element);
         }
 
         /**
          * @param {!WebInspector.Widget} view
          * @this {WebInspector.RequestPreviewView}
          */
         function handlePreviewView(view)
         {
-            this._previewView = view;
-            this._previewView.show(this.element);
-            if (this._previewView instanceof WebInspector.View) {
+            this.innerView = view;
+            this.innerView.show(this.element);
+            if (this.innerView instanceof WebInspector.View) {
                 var toolbar = new WebInspector.Toolbar("network-item-preview-toolbar", this.element);
-                for (var item of /** @type {!WebInspector.View} */ (this._previewView).toolbarItems())
+                for (var item of /** @type {!WebInspector.View} */ (this.innerView).toolbarItems())
                     toolbar.appendToolbarItem(item);
             }
-            this.innerView = this._previewView;
-            this._previewViewHandledForTest(this._previewView);
+            this._previewViewHandledForTest(this.innerView);
         }
     },
 
     /**
      * @param {!WebInspector.Widget} view
      */
     _previewViewHandledForTest: function(view) { },
 
     /**
      * @return {!WebInspector.EmptyWidget}
@@ skipping 99 matching lines @@
 
             if (this.request.resourceType() === WebInspector.resourceTypes.Other)
                 return this._createEmptyWidget();
 
             return WebInspector.RequestView.nonSourceViewForRequest(this.request);
         }
     },
 
     __proto__: WebInspector.RequestContentView.prototype
 }