third_party/WebKit/Source/core/css/CSSStyleSheet.cpp - Issue 2205843003: Use weak members to cache StyleSheetContents.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/CSSStyleSheet.cpp

Issue 2205843003: Use weak members to cache StyleSheetContents. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Might be in cache without being used before garbage collection Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/css/CSSStyleSheet.cpp

diff --git a/third_party/WebKit/Source/core/css/CSSStyleSheet.cpp b/third_party/WebKit/Source/core/css/CSSStyleSheet.cpp

index b02b81df3a76c6daa27eb9c8061d20bc6d2201b3..56a7481a7f7acc29ba2df185e4530fccc393e140 100644

--- a/third_party/WebKit/Source/core/css/CSSStyleSheet.cpp

+++ b/third_party/WebKit/Source/core/css/CSSStyleSheet.cpp

@@ -147,10 +147,8 @@ static bool isStyleElement(const Node* node)

void CSSStyleSheet::willMutateRules()

{

// If we are the only client it is safe to mutate.

- if (m_contents->clientSize() <= 1 && !m_contents->isReferencedFromResource()) {

+ if (!m_contents->isUsedFromTextCache() && !m_contents->isReferencedFromResource()) {

m_contents->clearRuleSet();

- if (Document* document = ownerDocument())

- m_contents->removeSheetFromCache(document);

m_contents->setMutable();

return;

}