Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(357)

Issue 2205813002: X87: Make FastNewFunctionContextStub take slots parameter. (Closed)

Created:
4 years, 4 months ago by zhengxing.li
Modified:
4 years, 4 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: Make FastNewFunctionContextStub take slots parameter. port 5bc243978396ab902f115e49aff2cf4bcb5d8a4c (r38219) original commit message: This will enable the interpreter to add a bytecode and use the stub. BUG= Committed: https://crrev.com/57fc9a7906cf6129e1fab66d6f9565a147e6034c Cr-Commit-Position: refs/heads/master@{#38271}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -20 lines) Patch
M src/crankshaft/x87/lithium-codegen-x87.cc View 1 chunk +4 lines, -5 lines 0 comments Download
M src/full-codegen/x87/full-codegen-x87.cc View 1 chunk +6 lines, -9 lines 0 comments Download
M src/x87/interface-descriptors-x87.cc View 2 chunks +5 lines, -6 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
zhengxing.li
PTAL, thanks!
4 years, 4 months ago (2016-08-02 08:51:23 UTC) #2
klaasb
lgtm
4 years, 4 months ago (2016-08-02 09:10:36 UTC) #3
Weiliang
lgtm
4 years, 4 months ago (2016-08-03 05:43:35 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2205813002/1
4 years, 4 months ago (2016-08-03 06:06:58 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-03 06:25:47 UTC) #7
commit-bot: I haz the power
4 years, 4 months ago (2016-08-03 06:28:22 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/57fc9a7906cf6129e1fab66d6f9565a147e6034c
Cr-Commit-Position: refs/heads/master@{#38271}

Powered by Google App Engine
This is Rietveld 408576698