Deprecation of ClassMetadata wrapper for Class formatters so a stand-alone class is recognizable.

Deprecation of ClassMetadata wrapper for Class formatters so a stand-alone class is recognizable.

BUG=
R=jacobr@google.com

Committed: https://github.com/dart-lang/dev_compiler/commit/c6f1ea6e6ab0f17afe335f4b59ed9719235ee14a

[bmilligan, 2016-08-02 00:30:33]

bmilligan@google.com changed reviewers:
+ alanknight@google.com, jacobr@google.com

[bmilligan, 2016-08-02 01:12:44]

https://codereview.chromium.org/2205733002/diff/20001/tool/input_sdk/private/...
File tool/input_sdk/private/debugger.dart (right):

https://codereview.chromium.org/2205733002/diff/20001/tool/input_sdk/private/...
tool/input_sdk/private/debugger.dart:34: Symbol isClass = JS('Symbol',
'Symbol("isClass")');
Using 'new Symbol('isClass') in Dart followed by JSNative.setProperty was
setting that as a property not a symbol, so I used the JS symbol.

[Jacob, 2016-08-02 01:45:12]

https://codereview.chromium.org/2205733002/diff/40001/tool/input_sdk/private/...
File tool/input_sdk/private/debugger.dart (right):

https://codereview.chromium.org/2205733002/diff/40001/tool/input_sdk/private/...
tool/input_sdk/private/debugger.dart:31: static const renderAsClass = const
JsonMLConfig("renderAsClass");
no need for the word render. These are all options for how objects are rendered.
change to 
asClass

https://codereview.chromium.org/2205733002/diff/40001/tool/input_sdk/private/...
tool/input_sdk/private/debugger.dart:413: if (config ==
JsonMLConfig.renderAsClass)
instead of special casing ClassFormatter here, pass the config to hasChildren,
etc.
Also, instead of making config an optional named argument make it a required
arg. That will avoid any bugs where you are not passing down the config where
you mean to.

https://codereview.chromium.org/2205733002/diff/40001/tool/input_sdk/private/...
tool/input_sdk/private/debugger.dart:781: accept(object) => object is Type;
change this accept method to take the JSONMLConfig as well. same idea as
checking whether safeGetProperty is true without the issue that the setting was
permanent.

https://codereview.chromium.org/2205733002/diff/40001/tool/input_sdk/private/...
tool/input_sdk/private/debugger.dart:784: // TODO(bmilligan): Tag classes with
generic types with a Symbol at their
this comment is obsolete

[bmilligan, 2016-08-02 16:28:40]

https://codereview.chromium.org/2205733002/diff/40001/tool/input_sdk/private/...
File tool/input_sdk/private/debugger.dart (right):

https://codereview.chromium.org/2205733002/diff/40001/tool/input_sdk/private/...
tool/input_sdk/private/debugger.dart:31: static const renderAsClass = const
JsonMLConfig("renderAsClass");
On 2016/08/02 01:45:11, Jacob wrote:
> no need for the word render. These are all options for how objects are
rendered.
> change to 
> asClass

Done.

https://codereview.chromium.org/2205733002/diff/40001/tool/input_sdk/private/...
tool/input_sdk/private/debugger.dart:413: if (config ==
JsonMLConfig.renderAsClass)
On 2016/08/02 01:45:12, Jacob wrote:
> instead of special casing ClassFormatter here, pass the config to hasChildren,
> etc.
> Also, instead of making config an optional named argument make it a required
> arg. That will avoid any bugs where you are not passing down the config where
> you mean to.

Done.

https://codereview.chromium.org/2205733002/diff/40001/tool/input_sdk/private/...
tool/input_sdk/private/debugger.dart:781: accept(object) => object is Type;
On 2016/08/02 01:45:11, Jacob wrote:
> change this accept method to take the JSONMLConfig as well. same idea as
> checking whether safeGetProperty is true without the issue that the setting
was
> permanent.

Done.

https://codereview.chromium.org/2205733002/diff/40001/tool/input_sdk/private/...
tool/input_sdk/private/debugger.dart:784: // TODO(bmilligan): Tag classes with
generic types with a Symbol at their
On 2016/08/02 01:45:12, Jacob wrote:
> this comment is obsolete

The emphasis on this comment is on the "generic type" classes, because classes
with generic types still aren't recognizable on their own. This symbol here
'genericTypeName' is set by me in the debugger, but ideally the generics should
be recognizable independently.

I moved the TODO to where that symbol is set on the object.

[Jacob, 2016-08-02 16:39:44]

lgtm

https://codereview.chromium.org/2205733002/diff/40001/tool/input_sdk/private/...
File tool/input_sdk/private/debugger.dart (right):

https://codereview.chromium.org/2205733002/diff/40001/tool/input_sdk/private/...
tool/input_sdk/private/debugger.dart:784: // TODO(bmilligan): Tag classes with
generic types with a Symbol at their
On 2016/08/02 16:28:39, bmilligan wrote:
> On 2016/08/02 01:45:12, Jacob wrote:
> > this comment is obsolete
> 
> The emphasis on this comment is on the "generic type" classes, because classes
> with generic types still aren't recognizable on their own. This symbol here
> 'genericTypeName' is set by me in the debugger, but ideally the generics
should
> be recognizable independently.
> 
> I moved the TODO to where that symbol is set on the object.

Acknowledged.

[bmilligan, 2016-08-02 16:43:30]

Description was changed from

==========
Deprecation of ClassMetadata wrapper for Class formatters so a stand-alone class
is recognizable.

BUG=
==========

to

==========
Deprecation of ClassMetadata wrapper for Class formatters so a stand-alone class
is recognizable.

BUG=
R=jacobr@google.com

Committed:
https://github.com/dart-lang/dev_compiler/commit/c6f1ea6e6ab0f17afe335f4b59ed...
==========

[bmilligan, 2016-08-02 16:43:32]

Committed patchset #6 (id:100001) manually as
c6f1ea6e6ab0f17afe335f4b59ed9719235ee14a (presubmit successful).