Quick View: Update UI to meet the latest mock.

Quick View: Update UI to meet the latest mock.

Mock is https://folio.googleplex.com/crosfilesapppreviewpane/High%20fidelity%20visuals/Quick%20View/Mocks%20&%20Specs/07_25_2016#%2FSPEC%20-%20Color%20scheme.png%3Fz=fit&c=show
We also need to update placeholder icons to https://drive.google.com/corp/drive/u/0/folders/0B0p7OJNHkJw8dkxZRWViS3BDd2c,
but I will do it in a separate CL.

BUG=632726
TEST=manually

Committed: https://crrev.com/cc7cad39f158404fdd538add739a68c1c49397b5
Cr-Commit-Position: refs/heads/master@{#409737}

[oka, 2016-08-03 09:17:38]

The CQ bit was checked by oka@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-03 09:17:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[oka, 2016-08-03 09:21:06]

oka@chromium.org changed reviewers:
+ fukino@chromium.org

[oka, 2016-08-03 09:21:07]

PTAL

[commit-bot: I haz the power, 2016-08-03 09:26:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-03 09:26:22]

Dry run: Try jobs failed on following builders:
  win_clang on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/...)

[fukino, 2016-08-03 09:56:31]

https://codereview.chromium.org/2205693006/diff/1/ui/file_manager/file_manage...
File ui/file_manager/file_manager/foreground/elements/files_metadata_entry.html
(right):

https://codereview.chromium.org/2205693006/diff/1/ui/file_manager/file_manage...
ui/file_manager/file_manager/foreground/elements/files_metadata_entry.html:31:
font-size: medium;
Use % or em to respect the users scale option and be consistent with other
files.

https://codereview.chromium.org/2205693006/diff/1/ui/file_manager/file_manage...
ui/file_manager/file_manager/foreground/elements/files_metadata_entry.html:33:
font-weight: bold;
Need to be removed?

https://codereview.chromium.org/2205693006/diff/1/ui/file_manager/file_manage...
File ui/file_manager/file_manager/foreground/elements/files_quick_view.css
(right):

https://codereview.chromium.org/2205693006/diff/1/ui/file_manager/file_manage...
ui/file_manager/file_manager/foreground/elements/files_quick_view.css:103:
--paper-toolbar-background: #282A2D;
Use rgb() notation.

https://codereview.chromium.org/2205693006/diff/1/ui/file_manager/file_manage...
ui/file_manager/file_manager/foreground/elements/files_quick_view.css:157:
background-color: #767679;
Use rgb().

https://codereview.chromium.org/2205693006/diff/1/ui/file_manager/file_manage...
ui/file_manager/file_manager/foreground/elements/files_quick_view.css:167:
font-size: medium;
Use % or em.

https://codereview.chromium.org/2205693006/diff/1/ui/file_manager/file_manage...
File ui/file_manager/file_manager/foreground/elements/files_quick_view.html
(right):

https://codereview.chromium.org/2205693006/diff/1/ui/file_manager/file_manage...
ui/file_manager/file_manager/foreground/elements/files_quick_view.html:15: <link
rel="import" href="icons.html">
This import looks unnecessary.

https://codereview.chromium.org/2205693006/diff/1/ui/file_manager/file_manage...
File ui/file_manager/file_manager/foreground/elements/files_ripple.js (right):

https://codereview.chromium.org/2205693006/diff/1/ui/file_manager/file_manage...
ui/file_manager/file_manager/foreground/elements/files_ripple.js:30: var node =
Polymer.dom(this.root).parentNode;
assert(node) looks natural, as we expect there is a parent node on attached().

[oka, 2016-08-04 02:27:26]

Address comments.

[oka, 2016-08-04 02:33:10]

PTAL.

https://codereview.chromium.org/2205693006/diff/1/ui/file_manager/file_manage...
File ui/file_manager/file_manager/foreground/elements/files_metadata_entry.html
(right):

https://codereview.chromium.org/2205693006/diff/1/ui/file_manager/file_manage...
ui/file_manager/file_manager/foreground/elements/files_metadata_entry.html:31:
font-size: medium;
On 2016/08/03 09:56:30, fukino wrote:
> Use % or em to respect the users scale option and be consistent with other
> files.

Done.

https://codereview.chromium.org/2205693006/diff/1/ui/file_manager/file_manage...
ui/file_manager/file_manager/foreground/elements/files_metadata_entry.html:33:
font-weight: bold;
On 2016/08/03 09:56:30, fukino wrote:
> Need to be removed?

Done.

https://codereview.chromium.org/2205693006/diff/1/ui/file_manager/file_manage...
File ui/file_manager/file_manager/foreground/elements/files_quick_view.css
(right):

https://codereview.chromium.org/2205693006/diff/1/ui/file_manager/file_manage...
ui/file_manager/file_manager/foreground/elements/files_quick_view.css:103:
--paper-toolbar-background: #282A2D;
On 2016/08/03 09:56:30, fukino wrote:
> Use rgb() notation.

Done.

https://codereview.chromium.org/2205693006/diff/1/ui/file_manager/file_manage...
ui/file_manager/file_manager/foreground/elements/files_quick_view.css:157:
background-color: #767679;
On 2016/08/03 09:56:30, fukino wrote:
> Use rgb().

Done.

https://codereview.chromium.org/2205693006/diff/1/ui/file_manager/file_manage...
ui/file_manager/file_manager/foreground/elements/files_quick_view.css:167:
font-size: medium;
On 2016/08/03 09:56:30, fukino wrote:
> Use % or em.

Done.

https://codereview.chromium.org/2205693006/diff/1/ui/file_manager/file_manage...
File ui/file_manager/file_manager/foreground/elements/files_quick_view.html
(right):

https://codereview.chromium.org/2205693006/diff/1/ui/file_manager/file_manage...
ui/file_manager/file_manager/foreground/elements/files_quick_view.html:15: <link
rel="import" href="icons.html">
On 2016/08/03 09:56:31, fukino wrote:
> This import looks unnecessary.

It's needed for open-in-new.

https://codereview.chromium.org/2205693006/diff/1/ui/file_manager/file_manage...
File ui/file_manager/file_manager/foreground/elements/files_ripple.js (right):

https://codereview.chromium.org/2205693006/diff/1/ui/file_manager/file_manage...
ui/file_manager/file_manager/foreground/elements/files_ripple.js:30: var node =
Polymer.dom(this.root).parentNode;
On 2016/08/03 09:56:31, fukino wrote:
> assert(node) looks natural, as we expect there is a parent node on attached().

Updated to take shadow dom's parent as a fallback.

[fukino, 2016-08-04 07:00:20]

lgtm with a nit.

https://codereview.chromium.org/2205693006/diff/40001/ui/file_manager/file_ma...
File ui/file_manager/file_manager/foreground/elements/files_quick_view.css
(right):

https://codereview.chromium.org/2205693006/diff/40001/ui/file_manager/file_ma...
ui/file_manager/file_manager/foreground/elements/files_quick_view.css:103:
--paper-toolbar-background: rgb(40,42,45);
nit: Spaces are needed after ','.

[oka, 2016-08-04 07:47:21]

https://codereview.chromium.org/2205693006/diff/40001/ui/file_manager/file_ma...
File ui/file_manager/file_manager/foreground/elements/files_quick_view.css
(right):

https://codereview.chromium.org/2205693006/diff/40001/ui/file_manager/file_ma...
ui/file_manager/file_manager/foreground/elements/files_quick_view.css:103:
--paper-toolbar-background: rgb(40,42,45);
On 2016/08/04 07:00:20, fukino wrote:
> nit: Spaces are needed after ','.

Done.

[oka, 2016-08-04 07:47:39]

The CQ bit was checked by oka@chromium.org

[oka, 2016-08-04 07:47:40]

The patchset sent to the CQ was uploaded after l-g-t-m from fukino@chromium.org
Link to the patchset: https://codereview.chromium.org/2205693006/#ps60001
(title: "Nit")

[commit-bot: I haz the power, 2016-08-04 07:47:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-04 08:17:00]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-08-04 08:18:09]

Description was changed from

==========
Quick View: Update UI to meet the latest mock.

Mock is
https://folio.googleplex.com/crosfilesapppreviewpane/High%20fidelity%20visual...
We also need to update placeholder icons to
https://drive.google.com/corp/drive/u/0/folders/0B0p7OJNHkJw8dkxZRWViS3BDd2c,
but I will do it in a separate CL.

BUG=632726
TEST=manually
==========

to

==========
Quick View: Update UI to meet the latest mock.

Mock is
https://folio.googleplex.com/crosfilesapppreviewpane/High%20fidelity%20visual...
We also need to update placeholder icons to
https://drive.google.com/corp/drive/u/0/folders/0B0p7OJNHkJw8dkxZRWViS3BDd2c,
but I will do it in a separate CL.

BUG=632726
TEST=manually

Committed: https://crrev.com/cc7cad39f158404fdd538add739a68c1c49397b5
Cr-Commit-Position: refs/heads/master@{#409737}
==========

[commit-bot: I haz the power, 2016-08-04 08:18:10]

Patchset 4 (id:??) landed as
https://crrev.com/cc7cad39f158404fdd538add739a68c1c49397b5
Cr-Commit-Position: refs/heads/master@{#409737}