Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(586)

Unified Diff: tools/gn/variables.cc

Issue 2205693005: Add bundle_deps_filter to create_bundle targets. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix value of kBundleDepsFilter. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/gn/variables.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/variables.cc
diff --git a/tools/gn/variables.cc b/tools/gn/variables.cc
index 948495cf7037c4671bc52cba176482a778941e68..f374934a5823851a36305081ae84020f5aae93df 100644
--- a/tools/gn/variables.cc
+++ b/tools/gn/variables.cc
@@ -608,6 +608,38 @@ const char kBundleResourcesDir_Help[] =
"\n"
" See \"gn help bundle_root_dir\" for examples.\n";
+const char kBundleDepsFilter[] = "bundle_deps_filter";
+const char kBundleDepsFilter_HelpShort[] =
+ "bundle_deps_filter: [label list] A list of labels that are filtered out.";
+const char kBundleDepsFilter_Help[] =
+ "bundle_deps_filter: [label list] A list of labels that are filtered out.\n"
+ "\n"
+ " A list of target labels.\n"
+ "\n"
+ " This list contains target label patterns that should be filtered out\n"
+ " when creating the bundle. Any target matching one of those label will\n"
+ " be removed from the dependencies of the create_bundle target.\n"
+ "\n"
+ " This is mostly useful when creating application extension bundle as\n"
+ " the application extension has access to runtime resources from the\n"
+ " application bundle and thus do not require a second copy.\n"
+ "\n"
+ " See \"gn help create_bundle\" for more information.\n"
+ "\n"
+ "Example\n"
+ "\n"
+ " create_bundle(\"today_extension\") {\n"
+ " deps = [\n"
+ " \"//base\"\n"
+ " ]\n"
+ " bundle_root_dir = \"$root_out_dir/today_extension.appex\"\n"
+ " bundle_deps_filter = [\n"
+ " # The extension uses //base but does not use any function calling\n"
+ " # into third_party/icu and thus does not need the icudtl.dat file.\n"
+ " \"//third_party/icu:icudata\",\n"
+ " ]\n"
+ " }\n";
+
const char kBundleExecutableDir[] = "bundle_executable_dir";
const char kBundleExecutableDir_HelpShort[] =
"bundle_executable_dir: "
@@ -1811,6 +1843,7 @@ const VariableInfoMap& GetTargetVariables() {
INSERT_VARIABLE(AssertNoDeps)
INSERT_VARIABLE(BundleRootDir)
INSERT_VARIABLE(BundleResourcesDir)
+ INSERT_VARIABLE(BundleDepsFilter)
INSERT_VARIABLE(BundleExecutableDir)
INSERT_VARIABLE(BundlePlugInsDir)
INSERT_VARIABLE(Cflags)
« no previous file with comments | « tools/gn/variables.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698