Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4546)

Unified Diff: build/config/ios/rules.gni

Issue 2205693005: Add bundle_deps_filter to create_bundle targets. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix build/config/ios/rules.gni. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/gn/bundle_data.h » ('j') | tools/gn/variables.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/config/ios/rules.gni
diff --git a/build/config/ios/rules.gni b/build/config/ios/rules.gni
index 4f01ddc21229e74d884a188d3462b93cb0aa5674..a7e32d1fd5ce2b9ad43346d2c93e2df867fcf1a8 100644
--- a/build/config/ios/rules.gni
+++ b/build/config/ios/rules.gni
@@ -206,10 +206,11 @@ template("ios_app_bundle") {
"*",
[
"bundle_deps",
+ "bundle_deps_filter",
"bundle_extension",
- "extra_system_frameworks",
"entitlements_path",
"extra_substitutions",
+ "extra_system_frameworks",
"info_plist",
"info_plist_target",
"output_name",
@@ -338,11 +339,12 @@ template("ios_app_bundle") {
"*",
[
"bundle_deps",
+ "bundle_deps_filter",
"bundle_extension",
- "extra_system_frameworks",
"data_deps",
"entitlements_path",
"extra_substitutions",
+ "extra_system_frameworks",
"info_plist",
"info_plist_target",
"output_name",
@@ -488,6 +490,7 @@ template("ios_app_bundle") {
create_bundle(target_name) {
forward_variables_from(invoker,
[
+ "bundle_deps_filter",
"data_deps",
"deps",
"public_deps",
@@ -610,6 +613,9 @@ template("ios_app_bundle") {
if (defined(invoker.bundle_deps)) {
assert(invoker.bundle_deps != [], "mark bundle_deps as used")
}
+ if (defined(invoker.bundle_deps_filter)) {
+ assert(invoker.bundle_deps_filter != [], "mark bundle_deps_filter as used")
+ }
}
set_defaults("ios_app_bundle") {
« no previous file with comments | « no previous file | tools/gn/bundle_data.h » ('j') | tools/gn/variables.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698