Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(313)

Issue 2205683002: MD Settings: Restore display: none for Bluetooth dialog. (Closed)

Created:
4 years, 4 months ago by dpapad
Modified:
4 years, 4 months ago
Reviewers:
stevenjb, michaelpg
CC:
arv+watch_chromium.org, chromium-reviews, dbeam+watch-settings_chromium.org, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, stevenjb+watch-md-settings_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: Restore display: none for Bluetooth dialog. BUG=633367 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/51163149b8acd7e0519dba287946a480a92df844 Cr-Commit-Position: refs/heads/master@{#409104}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M chrome/browser/resources/settings/bluetooth_page/bluetooth_device_dialog.html View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
dpapad
@Michael: It seems to me that the "layout vertical" CSS classes which are causing the ...
4 years, 4 months ago (2016-08-01 23:17:15 UTC) #3
dpapad
On 2016/08/01 at 23:17:15, dpapad wrote: > @Michael: It seems to me that the "layout ...
4 years, 4 months ago (2016-08-01 23:17:50 UTC) #4
dpapad
4 years, 4 months ago (2016-08-01 23:26:11 UTC) #6
stevenjb
lgtm
4 years, 4 months ago (2016-08-01 23:27:58 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2205683002/1
4 years, 4 months ago (2016-08-01 23:29:13 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-02 00:40:35 UTC) #10
commit-bot: I haz the power
4 years, 4 months ago (2016-08-02 00:44:28 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/51163149b8acd7e0519dba287946a480a92df844
Cr-Commit-Position: refs/heads/master@{#409104}

Powered by Google App Engine
This is Rietveld 408576698