Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 220563002: Remove HTMLFrameElement.location (Closed)

Created:
6 years, 8 months ago by philipj_slow
Modified:
6 years, 8 months ago
CC:
blink-reviews, Nils Barth (inactive), kojih, arv+blink, jsbell+bindings_chromium.org, sof, kouhei+bindings_chromium.org, abarth-chromium, marja+watch_chromium.org, dglazkov+blink, adamk+blink_chromium.org, haraken, Nate Chapin, watchdog-blink-watchlist_google.com, Inactive
Visibility:
Public.

Description

Remove HTMLFrameElement.location Intent to Deprecate and Remove: https://groups.google.com/a/chromium.org/d/msg/blink-dev/aLpDg8pviU0/dUbUt7jsvT4J javascriptURL-execution-context-frame-location-htmldom.html was identical to javascriptURL-execution-context-frame-src-htmldom.html apart from the attribute set, so remove it. javascriptURL-execution-context-frame-location-htmldom-uncaught.html tests code that was removed in V8HTMLFrameElementCustom.cpp and does not have a counterpart for the src attribute, so remove it too. BUG=358505 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170563

Patch Set 1 #

Patch Set 2 : fix tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -161 lines) Patch
M LayoutTests/fast/dom/element-attribute-js-null.html View 1 1 chunk +0 lines, -3 lines 0 comments Download
M LayoutTests/fast/dom/element-attribute-js-null-expected.txt View 1 1 chunk +0 lines, -1 line 0 comments Download
D LayoutTests/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-location-htmldom.html View 1 1 chunk +0 lines, -15 lines 0 comments Download
D LayoutTests/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-location-htmldom-expected.txt View 1 1 chunk +0 lines, -17 lines 0 comments Download
D LayoutTests/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-location-htmldom-uncaught.html View 1 1 chunk +0 lines, -39 lines 0 comments Download
D LayoutTests/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-location-htmldom-uncaught-expected.txt View 1 1 chunk +0 lines, -13 lines 0 comments Download
M Source/bindings/bindings.gypi View 1 1 chunk +0 lines, -1 line 0 comments Download
D Source/bindings/v8/custom/V8HTMLFrameElementCustom.cpp View 1 chunk +0 lines, -59 lines 0 comments Download
M Source/core/frame/UseCounter.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/HTMLFrameElement.idl View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/html/HTMLFrameElementBase.h View 2 chunks +1 line, -3 lines 0 comments Download
M Source/core/html/HTMLFrameElementBase.cpp View 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
philipj_slow
PTAL.
6 years, 8 months ago (2014-04-01 07:18:16 UTC) #1
jochen (gone - plz use gerrit)
lgtm
6 years, 8 months ago (2014-04-01 11:26:21 UTC) #2
philipj_slow
The CQ bit was checked by philipj@opera.com
6 years, 8 months ago (2014-04-01 12:14:03 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/220563002/20001
6 years, 8 months ago (2014-04-01 12:14:10 UTC) #4
commit-bot: I haz the power
6 years, 8 months ago (2014-04-01 13:29:20 UTC) #5
Message was sent while issue was closed. 
Change committed as 170563

Powered by Google App Engine
This is Rietveld 408576698