Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 2205553002: gn: Add asserts that libjpeg_turbo is not used on iOS. (Closed)

Created:
4 years, 4 months ago by Nico
Modified:
4 years, 4 months ago
Reviewers:
Dirk Pranke, sdefresne
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

gn: Add asserts that libjpeg_turbo is not used on iOS. It doesn't build there, and it wasn't part of the gyp build. Depends on https://codereview.chromium.org/2201963002/ BUG=633316 NOTRY=true Committed: https://crrev.com/f8f88bfae6f677924e236514142cc2687e90c44f Cr-Commit-Position: refs/heads/master@{#409560}

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M build/secondary/third_party/libjpeg_turbo/BUILD.gn View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/BUILD.gn View 1 2 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 28 (18 generated)
Nico
4 years, 4 months ago (2016-08-01 21:09:26 UTC) #2
Nico
ptal
4 years, 4 months ago (2016-08-03 15:23:20 UTC) #12
Dirk Pranke
lgtm, sorry for the delay (thought this was a webrtc-related CL).
4 years, 4 months ago (2016-08-03 15:30:46 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2205553002/40001
4 years, 4 months ago (2016-08-03 15:32:34 UTC) #16
Nico
On 2016/08/03 15:30:46, Dirk Pranke wrote: > lgtm, sorry for the delay (thought this was ...
4 years, 4 months ago (2016-08-03 15:33:07 UTC) #17
sdefresne
lgtm
4 years, 4 months ago (2016-08-03 16:22:54 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/203314)
4 years, 4 months ago (2016-08-03 17:23:10 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2205553002/40001
4 years, 4 months ago (2016-08-03 17:28:45 UTC) #24
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 4 months ago (2016-08-03 17:34:45 UTC) #26
commit-bot: I haz the power
4 years, 4 months ago (2016-08-03 17:36:43 UTC) #28
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/f8f88bfae6f677924e236514142cc2687e90c44f
Cr-Commit-Position: refs/heads/master@{#409560}

Powered by Google App Engine
This is Rietveld 408576698