|
|
Chromium Code Reviews
Descriptiongn: Add asserts that libjpeg_turbo is not used on iOS.
It doesn't build there, and it wasn't part of the gyp build.
Depends on https://codereview.chromium.org/2201963002/
BUG=633316
NOTRY=true
Committed: https://crrev.com/f8f88bfae6f677924e236514142cc2687e90c44f
Cr-Commit-Position: refs/heads/master@{#409560}
Patch Set 1 #Patch Set 2 : rebase #Patch Set 3 : comment #
Messages
Total messages: 28 (18 generated)
thakis@chromium.org changed reviewers: + dpranke@chromium.org
The CQ bit was checked by thakis@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by thakis@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by thakis@chromium.org to run a CQ dry run
thakis@chromium.org changed reviewers: + sdefresne@chromium.org
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
ptal
lgtm, sorry for the delay (thought this was a webrtc-related CL).
The CQ bit was unchecked by thakis@chromium.org
The CQ bit was checked by thakis@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
On 2016/08/03 15:30:46, Dirk Pranke wrote: > lgtm, sorry for the delay (thought this was a webrtc-related CL). Thanks! It's kind-of webrtc-related since webrtc used to pull this in (via libyuv; I changed that here https://codereview.chromium.org/2201963002/)
lgtm
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
Description was changed from ========== gn: Add asserts that libjpeg_turbo is not used on iOS. It doesn't build there, and it wasn't part of the gyp build. Depends on https://codereview.chromium.org/2201963002/ BUG=633316 ========== to ========== gn: Add asserts that libjpeg_turbo is not used on iOS. It doesn't build there, and it wasn't part of the gyp build. Depends on https://codereview.chromium.org/2201963002/ BUG=633316 NOTRY=ture ==========
Description was changed from ========== gn: Add asserts that libjpeg_turbo is not used on iOS. It doesn't build there, and it wasn't part of the gyp build. Depends on https://codereview.chromium.org/2201963002/ BUG=633316 NOTRY=ture ========== to ========== gn: Add asserts that libjpeg_turbo is not used on iOS. It doesn't build there, and it wasn't part of the gyp build. Depends on https://codereview.chromium.org/2201963002/ BUG=633316 NOTRY=true ==========
The CQ bit was checked by thakis@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== gn: Add asserts that libjpeg_turbo is not used on iOS. It doesn't build there, and it wasn't part of the gyp build. Depends on https://codereview.chromium.org/2201963002/ BUG=633316 NOTRY=true ========== to ========== gn: Add asserts that libjpeg_turbo is not used on iOS. It doesn't build there, and it wasn't part of the gyp build. Depends on https://codereview.chromium.org/2201963002/ BUG=633316 NOTRY=true ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== gn: Add asserts that libjpeg_turbo is not used on iOS. It doesn't build there, and it wasn't part of the gyp build. Depends on https://codereview.chromium.org/2201963002/ BUG=633316 NOTRY=true ========== to ========== gn: Add asserts that libjpeg_turbo is not used on iOS. It doesn't build there, and it wasn't part of the gyp build. Depends on https://codereview.chromium.org/2201963002/ BUG=633316 NOTRY=true Committed: https://crrev.com/f8f88bfae6f677924e236514142cc2687e90c44f Cr-Commit-Position: refs/heads/master@{#409560} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/f8f88bfae6f677924e236514142cc2687e90c44f Cr-Commit-Position: refs/heads/master@{#409560} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
