Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4482)

Unified Diff: chrome/test/data/extensions/api_test/tabs/basics/discarding.js

Issue 2205523002: AutoDiscardable property support on Chrome Extensions Tabs API. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: change javascript test Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/data/extensions/api_test/tabs/basics/discarding.js
diff --git a/chrome/test/data/extensions/api_test/tabs/basics/discarded.js b/chrome/test/data/extensions/api_test/tabs/basics/discarding.js
similarity index 56%
rename from chrome/test/data/extensions/api_test/tabs/basics/discarded.js
rename to chrome/test/data/extensions/api_test/tabs/basics/discarding.js
index 7d212a82c37aeeb40bcb08dc2ed444ea3d519d20..d0ffd24f3a198d4be14b19f53cd5f6935c0ae12a 100644
--- a/chrome/test/data/extensions/api_test/tabs/basics/discarded.js
+++ b/chrome/test/data/extensions/api_test/tabs/basics/discarding.js
@@ -20,6 +20,7 @@ chrome.test.runTests([
}));
},
+ // Tests chrome.tabs.onUpdated for Discarded property.
function discard() {
// Initially tab isn't discarded.
assertFalse(testTab.discarded);
@@ -70,5 +71,57 @@ chrome.test.runTests([
});
chrome.tabs.reload(testTab.id);
+ },
+
+ // Tests chrome.tabs.onUpdated for autoDiscardable property.
+ function setNonAutoDiscardable() {
+ // Initially the tab is auto-discardable.
+ assertTrue(testTab.autoDiscardable);
+
+ var onUpdatedCompleted = chrome.test.listenForever(
+ chrome.tabs.onUpdated,
+ function (tabId, changeInfo, tab) {
Devlin 2016/08/11 16:45:54 nit: no space after function
Anderson Silva 2016/08/11 17:26:57 Done.
+ if ('autoDiscardable' in changeInfo) {
+ // Make sure it's the right tab.
+ assertEq(testTab.id, tab.id);
+
+ // Make sure the auto-discardable state changed correctly.
+ assertFalse(changeInfo.autoDiscardable);
+ assertFalse(tab.autoDiscardable);
+
+ onUpdatedCompleted();
+ }
+ });
+
+ chrome.tabs.update(testTab.id, { autoDiscardable: false },
+ pass(function (tab) {
Devlin 2016/08/11 16:45:54 nit: no space after function
Anderson Silva 2016/08/11 17:26:57 Done.
+ assertFalse(tab.autoDiscardable);
+ testTab = tab;
+ }));
+ },
+
+ function resetAutoDiscardable() {
+ // Tab was set to non auto-discardable.
+ assertFalse(testTab.autoDiscardable);
+
+ var onUpdatedCompleted = chrome.test.listenForever(
+ chrome.tabs.onUpdated,
+ function (tabId, changeInfo, tab) {
Devlin 2016/08/11 16:45:54 ditto
Anderson Silva 2016/08/11 17:26:57 Done.
+ if ('autoDiscardable' in changeInfo) {
+ // Make sure it's the right tab.
+ assertEq(testTab.id, tab.id);
+
+ // Make sure the auto-discardable state changed correctly.
+ assertTrue(changeInfo.autoDiscardable);
+ assertTrue(tab.autoDiscardable);
+
+ onUpdatedCompleted();
+ }
+ });
+
+ chrome.tabs.update(testTab.id, { autoDiscardable: true },
+ pass(function (tab) {
+ assertTrue(tab.autoDiscardable);
+ }));
}
]);

Powered by Google App Engine
This is Rietveld 408576698