chrome/browser/extensions/extension_tabs_apitest.cc - Issue 2205523002: AutoDiscardable property support on Chrome Extensions Tabs API.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_tabs_apitest.cc

Issue 2205523002: AutoDiscardable property support on Chrome Extensions Tabs API. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: change javascript test Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/extension_tab_util.cc ('k') | chrome/common/extensions/api/tabs.json » ('j') | chrome/test/data/extensions/api_test/tabs/basics/discarded.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/extension_tabs_apitest.cc

diff --git a/chrome/browser/extensions/extension_tabs_apitest.cc b/chrome/browser/extensions/extension_tabs_apitest.cc

index 1ed844e4974d41b3553f97346a5e1267258a9c4a..c11050f36d29db19773c3194f99b121c54ca117e 100644

--- a/chrome/browser/extensions/extension_tabs_apitest.cc

+++ b/chrome/browser/extensions/extension_tabs_apitest.cc

@@ -277,8 +277,9 @@ IN_PROC_BROWSER_TEST_F(ExtensionApiTest, DISABLED_GetViewsOfCreatedWindow) {

<< message_;

}

-IN_PROC_BROWSER_TEST_F(ExtensionApiTest, DiscardedState) {

- ASSERT_TRUE(RunExtensionSubtest("tabs/basics", "discarded.html")) << message_;

+IN_PROC_BROWSER_TEST_F(ExtensionApiTest, OnUpdatedDiscardingStates) {

+ ASSERT_TRUE(RunExtensionSubtest("tabs/basics", "discarding.html"))

+ << message_;

}

// Adding a new test? Awesome. But API tests are the old hotness. The new