AutoDiscardable property support on Chrome Extensions Tabs API.

chrome/test/data/extensions/api_test/tabs/basics/autoDiscardable.js

Index: chrome/test/data/extensions/api_test/tabs/basics/autoDiscardable.js
diff --git a/chrome/test/data/extensions/api_test/tabs/basics/autoDiscardable.js b/chrome/test/data/extensions/api_test/tabs/basics/autoDiscardable.js
new file mode 100644
index 0000000000000000000000000000000000000000..8fa9c1b2e036593c9d1550a73acf3d1205892474
--- /dev/null
+++ b/chrome/test/data/extensions/api_test/tabs/basics/autoDiscardable.js
@@ -0,0 +1,73 @@
+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+var testTab;
+chrome.test.runTests([
+
+    function setupWindow() {
+      var testTabId;
+
+      createWindow(["about:blank", "chrome://newtab/"], {},
+                   pass(function(winId, tabIds) {
+        testTabId = tabIds[1];
+      }));
+
+      waitForAllTabs(pass(function() {
+        queryForTab(testTabId, {}, pass(function(tab) {
+          testTab = tab;
+        }));
+      }));
+    },
+
+    function setNonAutoDiscardable() {

[Devlin, 2016/08/02 22:48:14]

Can we combine this with the other discardable test?

[Anderson Silva, 2016/08/03 14:47:41]

You mean do set and reset (both update() calls) in the same function? 
Or test this in tabs_test.cc? We can't really test a onUpdated event
notification on tabs_test.cc (or we didn't find a way to do so). 

[Devlin, 2016/08/10 19:25:12]

I meant adding this to
chrome/test/data/extensions/api_test/tabs/basics/discarded.js in a separate
function to reduce boilerplate.

[Anderson Silva, 2016/08/10 20:30:53]

Hmm, I think it would work as well doing it altogether but they are different
properties and being so I would prefer to keep them separate.
Let me know.

[Devlin, 2016/08/10 20:45:49]

Extension javascript tests are designed to be able to run multiple tests in a
single browsertest, kind of like how we can do multiple assertions. 
chrome.test.runTests() runs all functions it's passed, and each function is
considered a separate test.  So what I'm recommending is keeping the tests
distinct, but running them in the same JS file and browsertest executable in
order to cut down on boilerplate and speed up browsertest execution time.  Does
that make sense?

[Devlin, 2016/08/10 20:48:01]

(here's an example:
https://cs.chromium.org/chromium/src/chrome/test/data/extensions/api_test/coo...)

[Anderson Silva, 2016/08/10 20:49:58]

Oh, I see you mean now. It's basically using the same functions within only one
file. I thought I was supposed to mix up the functions. I'll redo it then.
Thanks

+      // Initially the tab is auto-discardable.
+      assertTrue(testTab.autoDiscardable);
+
+      var onUpdatedCompleted = chrome.test.listenForever(
+          chrome.tabs.onUpdated,
+          function(tabId, changeInfo, tab) {
+        if ('autoDiscardable' in changeInfo) {
+          // Make sure it's the right tab.
+          assertEq(testTab.id, tab.id);
+
+          // Make sure the auto-discardable state changed correctly.
+          assertFalse(changeInfo.autoDiscardable);
+          assertFalse(tab.autoDiscardable);
+
+          onUpdatedCompleted();
+        }
+      });
+
+      chrome.tabs.update(testTab.id, { autoDiscardable: false },
+                         pass(function (tab) {
+        assertFalse(tab.autoDiscardable);
+        testTab = tab;
+      }));
+    },
+
+    function resetAutoDiscardable() {
+      // Tab was set to non auto-discardable.
+      assertFalse(testTab.autoDiscardable);
+
+      var onUpdatedCompleted = chrome.test.listenForever(
+          chrome.tabs.onUpdated,
+          function(tabId, changeInfo, tab) {
+            if ('autoDiscardable' in changeInfo) {
+              // Make sure it's the right tab.
+              assertEq(testTab.id, tab.id);
+
+              // Make sure the auto-discardable state changed correctly.
+              assertTrue(changeInfo.autoDiscardable);
+              assertTrue(tab.autoDiscardable);
+
+              onUpdatedCompleted();
+            }
+          });
+
+      chrome.tabs.update(testTab.id, { autoDiscardable: true },
+                         pass(function (tab) {
+        assertTrue(tab.autoDiscardable);
+      }));
+    }
+]);