Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(310)

Issue 2205513002: Pay attention to exports when determine which libraries to reload. (Closed)

Created:
4 years, 4 months ago by turnidge
Modified:
4 years, 4 months ago
Reviewers:
Cutch
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Pay attention to exports when determine which libraries to reload. Refactor unit testing framework functionality around imported test libraries. BUG= R=johnmccutchan@google.com Committed: https://github.com/dart-lang/sdk/commit/248ee5227bb1b184105907298e7a997f4d448bff

Patch Set 1 #

Patch Set 2 : Pay attention to exports when determine which libraries to reload. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+158 lines, -72 lines) Patch
M runtime/vm/isolate_reload.cc View 3 chunks +17 lines, -7 lines 0 comments Download
M runtime/vm/isolate_reload_test.cc View 17 chunks +105 lines, -38 lines 0 comments Download
M runtime/vm/unit_test.h View 1 chunk +2 lines, -3 lines 0 comments Download
M runtime/vm/unit_test.cc View 1 2 chunks +34 lines, -24 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
turnidge
4 years, 4 months ago (2016-08-01 20:23:51 UTC) #2
Cutch
LGTM!
4 years, 4 months ago (2016-08-01 20:29:26 UTC) #3
turnidge
4 years, 4 months ago (2016-08-01 20:35:27 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
248ee5227bb1b184105907298e7a997f4d448bff (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698