Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(645)

Issue 2205453002: Exposing CacheEntryStatus (former TransactionPattern) via UrlRequest (Closed)

Created:
4 years, 4 months ago by twifkak
Modified:
4 years, 4 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2785
Target Ref:
refs/pending/branch-heads/2785
Project:
chromium
Visibility:
Public.

Description

Exposing CacheEntryStatus (former TransactionPattern) via UrlRequest This will allow to know how the UrlRequest affected the cache. Currently, it was possible to retrieve: cache used = was_cached && !network_accessed cache validated = was_cached && network_accessed not used/updated/cantconditionalize = !was_cached This change allows to tell apart the not used/updated/cantconditionalize sub-categories. This change has the added benefit that HttpCacheTransaction::RecordHistograms could be refactorized out of that class and moved to upper layers. BUG=615434 Review-Url: https://codereview.chromium.org/2113603003 Cr-Commit-Position: refs/heads/master@{#407971} (cherry picked from commit 19ff6f1bd9d1ea24e3104d0cbec6352640545d8c) Committed: https://chromium.googlesource.com/chromium/src/+/8939e8c9152b2afd54bfbd8400af6cc61706d6c1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+242 lines, -84 lines) Patch
M net/http/http_cache_transaction.h View 3 chunks +17 lines, -21 lines 0 comments Download
M net/http/http_cache_transaction.cc View 35 chunks +99 lines, -63 lines 0 comments Download
M net/http/http_cache_unittest.cc View 4 chunks +92 lines, -0 lines 0 comments Download
M net/http/http_response_info.h View 2 chunks +31 lines, -0 lines 0 comments Download
M net/http/http_response_info.cc View 3 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
twifkak
4 years, 4 months ago (2016-08-01 19:35:32 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
8939e8c9152b2afd54bfbd8400af6cc61706d6c1.

Powered by Google App Engine
This is Rietveld 408576698