Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(637)

Issue 2205433002: Implement ALPN in tlslite. (Closed)

Created:
4 years, 4 months ago by Bence
Modified:
4 years, 4 months ago
Reviewers:
davidben
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Implement ALPN in tlslite. * Update SSLClientSocketFalseStartTests to use ALPN. * Add SSLClientSocketTest test cases for ALPN. * Implement ALPN in tlslite. * Plumb ALPN through SpawnedTestServer. * Configure server ALPN for URLRequest tests so that connection does not fail. Note that the ALPN implementation introduced by this CL does not conform to the RFC: if there is no overlap between client and server supported protocols, ALPN is ignored, whereas the specification prescribes an Alert to be sent. This by the way matches BoringSSL's implementation. Also, it is simpler for tests: most net_unittests against tlslite do not worry about the actual protocol negotiated, and this way there is no need to configure the server ALPN list. BUG=547867 Committed: https://crrev.com/b784c2f5e0e4041f2ccb4949c3a8b4c45a30b16c Cr-Commit-Position: refs/heads/master@{#410127}

Patch Set 1 #

Patch Set 2 : Rebase. #

Patch Set 3 : Configure server ALPN for URLRequestTests. #

Patch Set 4 : One small fix. #

Patch Set 5 : Remove no_application_protocol alert. #

Patch Set 6 : Rebase. #

Total comments: 16

Patch Set 7 : Re: #20. #

Patch Set 8 : Rebase; update alpn.patch. #

Total comments: 14

Patch Set 9 : Re: #26. #

Patch Set 10 : Update alpn.patch. #

Patch Set 11 : Fix typo in comment. #

Patch Set 12 : Update alpn.patch. #

Total comments: 2

Patch Set 13 : Moving nextProtos back to where it was. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+545 lines, -60 lines) Patch
M net/socket/ssl_client_socket_unittest.cc View 1 2 3 4 5 6 7 8 10 chunks +82 lines, -28 lines 0 comments Download
M net/test/spawned_test_server/base_test_server.h View 1 chunk +3 lines, -0 lines 0 comments Download
M net/test/spawned_test_server/base_test_server.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M net/tools/testserver/testserver.py View 1 2 3 4 5 6 7 8 9 10 11 12 4 chunks +10 lines, -4 lines 0 comments Download
M third_party/tlslite/README.chromium View 1 chunk +1 line, -0 lines 0 comments Download
A third_party/tlslite/patches/alpn.patch View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +331 lines, -0 lines 0 comments Download
M third_party/tlslite/tlslite/constants.py View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M third_party/tlslite/tlslite/handshakesettings.py View 1 2 3 4 5 6 7 8 9 10 11 12 3 chunks +8 lines, -0 lines 0 comments Download
M third_party/tlslite/tlslite/messages.py View 1 2 3 4 5 6 7 8 9 10 11 12 12 chunks +64 lines, -25 lines 0 comments Download
M third_party/tlslite/tlslite/tlsconnection.py View 1 2 3 4 5 6 7 8 9 10 11 12 8 chunks +38 lines, -3 lines 0 comments Download

Messages

Total messages: 38 (26 generated)
Bence
David: please help me debug flaky HTTPSSessionTest.DontResumeSessionsForInvalidCertificates.
4 years, 4 months ago (2016-08-02 20:02:51 UTC) #11
davidben
Man, I'd forgotten how bad this stack was... poking about now, but one quick comment: ...
4 years, 4 months ago (2016-08-02 20:28:43 UTC) #12
Bence
David, PTAL. On 2016/08/02 20:28:43, davidben wrote: > Man, I'd forgotten how bad this stack ...
4 years, 4 months ago (2016-08-03 15:28:51 UTC) #19
davidben
(Did you manage to sort out the test flake. I wasn't sure. Sorry I didn't ...
4 years, 4 months ago (2016-08-03 23:34:22 UTC) #20
Bence
David: PTAL. On 2016/08/03 23:34:22, davidben wrote: > Did you manage to sort out the ...
4 years, 4 months ago (2016-08-04 18:41:45 UTC) #25
davidben
https://codereview.chromium.org/2205433002/diff/140001/third_party/tlslite/tlslite/messages.py File third_party/tlslite/tlslite/messages.py (right): https://codereview.chromium.org/2205433002/diff/140001/third_party/tlslite/tlslite/messages.py#newcode102 third_party/tlslite/tlslite/messages.py:102: def parse_next_protos(self, b): Having this as a method of ...
4 years, 4 months ago (2016-08-04 22:29:26 UTC) #26
Bence
PTAL. Thank you. https://codereview.chromium.org/2205433002/diff/140001/third_party/tlslite/tlslite/messages.py File third_party/tlslite/tlslite/messages.py (right): https://codereview.chromium.org/2205433002/diff/140001/third_party/tlslite/tlslite/messages.py#newcode102 third_party/tlslite/tlslite/messages.py:102: def parse_next_protos(self, b): On 2016/08/04 22:29:26, ...
4 years, 4 months ago (2016-08-05 14:27:55 UTC) #29
davidben
lgtm with one comment. https://codereview.chromium.org/2205433002/diff/220001/third_party/tlslite/tlslite/tlsconnection.py File third_party/tlslite/tlslite/tlsconnection.py (left): https://codereview.chromium.org/2205433002/diff/220001/third_party/tlslite/tlslite/tlsconnection.py#oldcode340 third_party/tlslite/tlslite/tlsconnection.py:340: nextProtos=None, reqTack=True, serverName="", It looks ...
4 years, 4 months ago (2016-08-05 15:59:34 UTC) #30
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2205433002/240001
4 years, 4 months ago (2016-08-05 17:57:35 UTC) #33
Bence
Thank you. https://codereview.chromium.org/2205433002/diff/220001/third_party/tlslite/tlslite/tlsconnection.py File third_party/tlslite/tlslite/tlsconnection.py (left): https://codereview.chromium.org/2205433002/diff/220001/third_party/tlslite/tlslite/tlsconnection.py#oldcode340 third_party/tlslite/tlslite/tlsconnection.py:340: nextProtos=None, reqTack=True, serverName="", On 2016/08/05 15:59:34, davidben ...
4 years, 4 months ago (2016-08-05 17:57:45 UTC) #34
commit-bot: I haz the power
Committed patchset #13 (id:240001)
4 years, 4 months ago (2016-08-05 19:09:56 UTC) #36
commit-bot: I haz the power
4 years, 4 months ago (2016-08-05 19:11:53 UTC) #38
Message was sent while issue was closed.
Patchset 13 (id:??) landed as
https://crrev.com/b784c2f5e0e4041f2ccb4949c3a8b4c45a30b16c
Cr-Commit-Position: refs/heads/master@{#410127}

Powered by Google App Engine
This is Rietveld 408576698