Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(629)

Issue 2205423002: webrtc content_browsetests file/class naming cleanup (Closed)

Created:
4 years, 4 months ago by mcasas
Modified:
4 years, 4 months ago
CC:
chromium-reviews, jam, darin-cc_chromium.org, kjellander_chromium, ehmaldonado_chromium
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

webrtc content_browsetests file/class naming cleanup *No new code * This CL cleans up a bit of class/file naming inconsistencies in webrtc content_browsertests: - content/browser/webrtc/webrtc_ip_permissions_browsertest.cc: renamed classes WebRtcBrowserIP* --> WebRtcIP*, to comply with file and test naming conventions - s/WebRtcContentBrowserTest/WebRtcContentBrowserTestBase/ everywhere - git cl format of the remaining. BUG=633257 Committed: https://crrev.com/41f5b700af96121fa474916afcf522c51d029894 Cr-Commit-Position: refs/heads/master@{#409609}

Patch Set 1 #

Messages

Total messages: 16 (6 generated)
mcasas
chfremer@ PTAL (kjellander@ + ehmaldonado@ FYI)
4 years, 4 months ago (2016-08-03 17:56:44 UTC) #2
mcasas
emircan@ PTAL
4 years, 4 months ago (2016-08-03 19:13:06 UTC) #4
chfremer
lgtm
4 years, 4 months ago (2016-08-03 19:28:12 UTC) #6
mcasas
nick@ Owners RS plz
4 years, 4 months ago (2016-08-03 19:34:55 UTC) #8
ncarter (slow)
lgtm
4 years, 4 months ago (2016-08-03 19:37:43 UTC) #9
emircan
lgtm
4 years, 4 months ago (2016-08-03 19:39:39 UTC) #10
emircan
lgtm
4 years, 4 months ago (2016-08-03 19:39:40 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2205423002/1
4 years, 4 months ago (2016-08-03 19:41:31 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-03 20:19:56 UTC) #14
commit-bot: I haz the power
4 years, 4 months ago (2016-08-03 20:21:12 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/41f5b700af96121fa474916afcf522c51d029894
Cr-Commit-Position: refs/heads/master@{#409609}

Powered by Google App Engine
This is Rietveld 408576698