Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Unified Diff: components/cast_certificate/cast_crl.h

Issue 2205403002: Add production Cast CRL certificate. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addresses comments Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/cast_certificate/cast_cert_validator.cc ('k') | components/cast_certificate/cast_crl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/cast_certificate/cast_crl.h
diff --git a/components/cast_certificate/cast_crl.h b/components/cast_certificate/cast_crl.h
index e95faf4861d630d3a37aa224b82dfe3c8d1842e3..f7d102a9b6b8fa63938fa12cc34109213e39e8fe 100644
--- a/components/cast_certificate/cast_crl.h
+++ b/components/cast_certificate/cast_crl.h
@@ -14,6 +14,10 @@
#include "base/time/time.h"
#include "net/cert/internal/parsed_certificate.h"
+namespace net {
+class TrustStore;
+}
+
namespace cast_certificate {
// This class represents the CRL information parsed from the binary proto.
@@ -40,7 +44,7 @@ class CastCRL {
};
// Parses and verifies the CRL used to verify the revocation status of
-// Cast device certificates.
+// Cast device certificates, using the built-in Cast CRL trust anchors.
//
// Inputs:
// * |crl_proto| is a serialized cast_certificate.CrlBundle proto.
@@ -53,11 +57,11 @@ std::unique_ptr<CastCRL> ParseAndVerifyCRL(const std::string& crl_proto,
// Exposed only for testing, not for use in production code.
//
-// Replaces trusted root certificates into the CastCRLTrustStore.
-//
-// Output:
-// Returns true if successful, false if nothing is changed.
-bool SetCRLTrustAnchorForTest(const std::string& cert) WARN_UNUSED_RESULT;
+// This is an overloaded version of ParseAndVerifyCRL that allows
+// the input of a custom TrustStore.
+std::unique_ptr<CastCRL> ParseAndVerifyCRLForTest(const std::string& crl_proto,
+ const base::Time& time,
+ net::TrustStore* trust_store);
} // namespace cast_certificate
« no previous file with comments | « components/cast_certificate/cast_cert_validator.cc ('k') | components/cast_certificate/cast_crl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698