Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(603)

Unified Diff: components/cast_certificate/cast_crl.h

Issue 2205403002: Add production Cast CRL certificate. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: TrustStore as explicit dependency for testing verify functions. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/cast_certificate/cast_crl.h
diff --git a/components/cast_certificate/cast_crl.h b/components/cast_certificate/cast_crl.h
index e95faf4861d630d3a37aa224b82dfe3c8d1842e3..277afe33cd49014e2faedfa00f224a81ead7aee9 100644
--- a/components/cast_certificate/cast_crl.h
+++ b/components/cast_certificate/cast_crl.h
@@ -14,6 +14,10 @@
#include "base/time/time.h"
#include "net/cert/internal/parsed_certificate.h"
+namespace net {
+class TrustStore;
+}
+
namespace cast_certificate {
// This class represents the CRL information parsed from the binary proto.
@@ -53,6 +57,14 @@ std::unique_ptr<CastCRL> ParseAndVerifyCRL(const std::string& crl_proto,
// Exposed only for testing, not for use in production code.
//
+// This is an overloaded version of ParseAndVerifyCRL that allows
+// the input of a custom TrustStore.
+std::unique_ptr<CastCRL> ParseAndVerifyCRLForTest(const std::string& crl_proto,
+ const base::Time& time,
+ net::TrustStore& trust_store);
eroman 2016/08/04 19:28:53 Same comment as elsewhere (pointer or const-refere
ryanchung 2016/08/04 21:56:53 Done.
+
+// Exposed only for testing, not for use in production code.
+//
// Replaces trusted root certificates into the CastCRLTrustStore.
//
// Output:

Powered by Google App Engine
This is Rietveld 408576698