Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(166)

Unified Diff: components/cast_certificate/cast_cert_validator.h

Issue 2205403002: Add production Cast CRL certificate. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: TrustStore as explicit dependency for testing verify functions. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/cast_certificate/cast_cert_validator.h
diff --git a/components/cast_certificate/cast_cert_validator.h b/components/cast_certificate/cast_cert_validator.h
index be924be74da3713f8f2ec81db1c05b24d6642f87..fd8e315958bcf6ca42b403eafb026e0832b18282 100644
--- a/components/cast_certificate/cast_cert_validator.h
+++ b/components/cast_certificate/cast_cert_validator.h
@@ -14,6 +14,9 @@
#include "base/strings/string_piece.h"
#include "base/time/time.h"
+namespace net {
+class TrustStore;
+}
namespace cast_certificate {
class CastCRL;
@@ -95,6 +98,18 @@ bool VerifyDeviceCert(const std::vector<std::string>& certs,
const CastCRL* crl,
CRLPolicy crl_policy) WARN_UNUSED_RESULT;
+// Exposed only for testing, not for use in production code.
+//
+// This is an overloaded version of VerifyDeviceCert that allows
+// the input of a custom TrustStore.
+bool VerifyDeviceCertForTest(const std::vector<std::string>& certs,
+ const base::Time& time,
+ std::unique_ptr<CertVerificationContext>* context,
+ CastDeviceCertPolicy* policy,
+ const CastCRL* crl,
+ CRLPolicy crl_policy,
+ net::TrustStore& trust_store) WARN_UNUSED_RESULT;
eroman 2016/08/04 19:28:52 Same comment as elsewhere (pointer or const-refere
ryanchung 2016/08/04 21:56:52 Done.
+
// Exposed only for unit-tests, not for use in production code.
// Production code would get a context from VerifyDeviceCert().
//
« no previous file with comments | « no previous file | components/cast_certificate/cast_cert_validator.cc » ('j') | components/cast_certificate/cast_cert_validator.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698